chrome/test/mini_installer_test/data/chrome_installed.prop - Issue 20578004: Initial commit for the Automated Installer Testing Framework.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/mini_installer_test/data/chrome_installed.prop

Issue 20578004: Initial commit for the Automated Installer Testing Framework. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 {
	gab 2013/07/31 13:45:16 As suggested earlier, how about putting these in a As suggested earlier, how about putting these in a config/ directory rather than data/? This is more inline with what these files actually are imo.. sukolsak 2013/07/31 18:20:30 Done. Show quoted text On 2013/07/31 13:45:16, gab wrote: > As suggested earlier, how about putting these in a config/ directory rather than > data/? > > This is more inline with what these files actually are imo.. Done.
	2 "RegistryEntries": {

	3 "HKEY_CURRENT_USER\\Software\\Google\\Update\\Clients\\{8A69D345-D564-463c-A FF1-A69D9E530F96}": {"expected": true}
	gab 2013/07/30 20:44:14 Wrap {"expected": true} to the next line, 4 extra Wrap {"expected": true} to the next line, 4 extra spaces in, to try to respect the 80 columns rule as best as possible (I don't think breaking down the key's path itself is necessary). Same comment for all other such json files. grt (UTC plus 2) 2013/07/31 17:20:05 Strictly speaking, the presence/absence of the reg Strictly speaking, the presence/absence of the registry value named "pv" within the Clients key is the thing that indicates to Google Update that a product is installed. I think the framework should make the same test. Ultimately, the framework should verify that the version number present in the "pv" registry value is the one that was expected given the install/update operation that preceded the verification. Please at least put a TODO somewhere that this should be fixed down the road. gab 2013/07/31 17:46:19 Eventually the goal is to have ALL the registry va Show quoted text On 2013/07/31 17:20:05, grt (no reviews Aug 3-11) wrote: > Strictly speaking, the presence/absence of the registry value named "pv" within > the Clients key is the thing that indicates to Google Update that a product is > installed. I think the framework should make the same test. > > Ultimately, the framework should verify that the version number present in the > "pv" registry value is the one that was expected given the install/update > operation that preceded the verification. > > Please at least put a TODO somewhere that this should be fixed down the road. Eventually the goal is to have ALL the registry values listed here; so I think it's ok for now to leave it as an implied TODO that this list will grow (since we can't put comments in JSON anyways...). sukolsak 2013/07/31 18:20:30 Done. Show quoted text On 2013/07/30 20:44:14, gab wrote: > Wrap {"expected": true} to the next line, 4 extra spaces in, to try to respect > the 80 columns rule as best as possible (I don't think breaking down the key's > path itself is necessary). > > Same comment for all other such json files. Done.
	4 }

	5 }

OLD	NEW

« no previous file with comments | « no previous file | chrome/test/mini_installer_test/data/chrome_not_installed.prop » ('j') | chrome/test/mini_installer_test/data/config.config » ('J')