Initial commit for the Automated Installer Testing Framework.

chrome/installer/automation_test/verifier.py

+# Copyright (c) 2012 The Chromium Authors. All rights reserved.

[gab, 2013/07/26 20:39:48]

2013

+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import _winreg
+
+def Verify(config):
+  for verifier_name, value in config.iteritems():
+    if verifier_name == "RegistryEntries":

[gab, 2013/07/26 20:39:48]

Is there some kind of switch statement for strings in python? If so, could be
nice to use here

[sukolsak, 2013/07/30 15:40:32]

Python doesn't have a switch statement.

+      VerifyRegistryEntries(value)
+    else:
+      # TODO: implement other verifiers

[robertshield, 2013/07/26 19:32:23]

TODOs should be attributed:
# TODO(sukolsak): implement...

+      pass
+
+def VerifyRegistryEntries(entries):

[gab, 2013/07/26 20:39:48]

I would put individual verifiers in their own module our this file will get
huge!

+  for key, entry in entries.iteritems():
+    if VerifyRegistryEntry(key, entry):
+      print "Passed"
+    else:
+      print "Failed"
+
+def RootKeyConstant(key):
+  if key == "HKEY_CLASSES_ROOT":
+    return _winreg.HKEY_CLASSES_ROOT
+  if key == "HKEY_CURRENT_USER":
+    return _winreg.HKEY_CURRENT_USER
+  if key == "HKEY_LOCAL_MACHINE":
+    return _winreg.HKEY_LOCAL_MACHINE
+  if key == "HKEY_USERS":
+    return _winreg.HKEY_USERS
+  raise Exception("Unknown registry key")
+
+def VerifyRegistryEntry(key, entry):
+  expected = entry["expected"]
+  print "        - " + key

[gab, 2013/07/26 20:39:48]

Constantify/document arbitrary formatting spaces

+  if expected:
+    print " exists..."
+  else:
+    print " doesn't exist..."
+  try:
+    root_key, sub_key = key.split("\\", 1)
+    reg_key = _winreg.OpenKey(RootKeyConstant(root_key), \

[gab, 2013/07/26 20:39:48]

Why do you need a backslash here? (Sorry if this is obvious I don't know python
much)

+      sub_key, 0, _winreg.KEY_READ)
+    if expected == False:
+      return False
+    if "value" in entry:
+      # TODO: implement value

[gab, 2013/07/26 20:39:48]

Name your TODO, i.e., TODO(sukolsak)

+      pass
+    return True
+  except WindowsError:
+    return expected == False