Initial commit for the Automated Installer Testing Framework.

chrome/installer/automation_test/test_installer.py

+# Copyright (c) 2012 The Chromium Authors. All rights reserved.

[gab, 2013/07/26 20:39:48]

2013

+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import argparse
+import json
+import subprocess
+import verifier
+
+class Config:
+  def __init__(self):
+    self.states = {}
+    self.actions = {}
+    self.tests = []
+
+# Merge the new Property object into the current Property object
+def MergeProperties(current_property, new_property):
+  for key, value in new_property.iteritems():
+    if key not in current_property:
+      current_property[key] = value
+    else:
+      assert(isinstance(current_property[key], dict) and \

[robertshield, 2013/07/26 19:32:23]

\ not needed here

+        isinstance(value, dict))
+      current_property[key] = \
+        dict(current_property[key].items() + value.items())

[robertshield, 2013/07/26 19:32:23]

hanging indents (that continue a statement) are usually four spaces

it would also be ok to write

current_property[key] = dict(
    current_property[key.items() + value.items())

[gab, 2013/07/26 20:39:48]

This is the overriding merge I like but Robert doesn't, right? :)

This seems easier than one that adds yet doesn't override existing values :).

+
+# Parse a .prop file
+def ParseProperty(property_filename):
+  property_file = open(property_filename, "r")
+  property = json.load(property_file)
+  property_file.close()
+  return property
+

[robertshield, 2013/07/26 19:32:23]

I believe it is two blank lines between top-level function definitions.

[gab, 2013/07/26 20:39:48]

We should get someone with python readability to take a look after we agree with
the fundamentals.

+# Parse an array of .prop files
+def ParseProperties(property_filenames):
+  current_property = {}
+  for property_filename in property_filenames:
+    new_property = ParseProperty(property_filename)
+    MergeProperties(current_property, new_property)
+  return current_property
+
+# Parse a .config file
+def ParseConfig(config_filename):
+  config = Config()
+
+  config_file = open(config_filename, "r")
+  config_data = json.load(config_file)
+  config_file.close()
+
+  for state_name, state_property_filenames in config_data["states"]:
+    config.states[state_name] = ParseProperties(state_property_filenames)
+  for action_name, action_command in config_data["actions"]:
+    config.actions[action_name] = action_command
+  config.tests = config_data["tests"]
+  return config
+
+# Verify that the current machine states match the given machine states
+def VerifyState(config, state):
+  print "    * Current state: " + state

[gab, 2013/07/26 20:39:48]

What's the idea behind spaces + *? I guess it makes the output nicer? I suggest
making that prefix a constant to make it clear what it achieves and avoid having
to perfectly replicate it everywhere.

+  verifier.Verify(config.states[state])
+
+def RunCommand(command):
+  print "    * Run command: " + command + "\n"
+  subprocess.call(command, shell=True)
+
+def RunResetCommand():
+  print "    * Reset\n"
+  subprocess.call("mini_installer.exe --chrome --uninstall"

[gab, 2013/07/26 20:39:48]

I don't actually think that works... I don't think the installer can uninstall
another install.

I would say simply don't add a way to reset for now while we figure how exactly
we want to reset.

+    + " & mini_installer.exe --chrome-frame --uninstall", shell=True) # FIXME

[robertshield, 2013/07/26 19:32:23]

indent 2 more

+
+# Test the installer
+def Test(config):
+  for test in config.tests:
+    print "Testing [ " + " -> ".join(test) + " ]"

[gab, 2013/07/26 20:39:48]

What does this print exactly? The format appears weird to me, or is this more
python magic?!

[sukolsak, 2013/07/30 15:40:32]

It joins the strings in the array with " -> ". So, it basically prints "state ->
action -> state -> ... -> state". I will make it clearer.

+
+    RunResetCommand()
+
+    current_state = test[0]
+    VerifyState(config, current_state)
+
+    for i in range(1, len(test), 2):

[gab, 2013/07/26 20:39:48]

Perhaps assert that len(tests) is odd before running this loop with a comment
shortly explaining the expected format?

+      action = test[i]
+      RunCommand(config.actions[action])
+
+      current_state = test[i + 1]
+      VerifyState(config, current_state)
+
+def main():
+  parser = argparse.ArgumentParser(description="Test the installer.")
+  parser.add_argument("config_filename", help="the config file")
+  args = parser.parse_args()
+
+  config = ParseConfig(args.config_filename)
+  Test(config)
+
+if __name__ == "__main__":
+  main()