Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Issue 2057793002: Reorganize event mojom files. (Closed)

Created:
4 years, 6 months ago by Hadi
Modified:
4 years, 6 months ago
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, tdresser+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, kalyank, darin (slow to review), ben+mojo_chromium.org, Fady Samuel
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reorganize event mojom files. * Moves input_events.mojom to //ui/events/mojo/event.mojom. * Moves input_event_constants.mojom to //ui/events/mojo/event_constants.mojom. * Moves input_key_codes.mojom to //ui/events/mojo/keyboard_codes.mojom. BUG=618808 Committed: https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448 Cr-Commit-Position: refs/heads/master@{#399454}

Patch Set 1 #

Patch Set 2 : rebase. #

Patch Set 3 : Fixed trybot errors. #

Patch Set 4 : Fixed typos in comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -583 lines) Patch
M ash/mus/accelerator_registrar_unittest.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M ash/mus/root_window_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/mus/window_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/common/event_matcher_util.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/mus/common/event_matcher_util.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M components/mus/public/cpp/tests/window_tree_client_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/mus/public/cpp/window_manager_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/interfaces/BUILD.gn View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M components/mus/public/interfaces/accelerator_registrar.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/public/interfaces/event_matcher.mojom View 3 chunks +10 lines, -10 lines 0 comments Download
D components/mus/public/interfaces/input_event_constants.mojom View 1 chunk +0 lines, -64 lines 0 comments Download
D components/mus/public/interfaces/input_events.mojom View 1 chunk +0 lines, -119 lines 0 comments Download
D components/mus/public/interfaces/input_key_codes.mojom View 1 chunk +0 lines, -188 lines 0 comments Download
M components/mus/public/interfaces/window_manager.mojom View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/interfaces/window_tree.mojom View 2 chunks +3 lines, -3 lines 0 comments Download
M components/mus/ws/accelerator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/ws/accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/event_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/event_dispatcher.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/mus/ws/event_dispatcher_unittest.cc View 1 4 chunks +16 lines, -16 lines 0 comments Download
M components/mus/ws/event_matcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/ws/event_matcher.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M components/mus/ws/event_matcher_unittest.cc View 1 4 chunks +7 lines, -7 lines 0 comments Download
M components/mus/ws/window_manager_state.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/mus/ws/window_manager_state_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/mus/ws/window_tree.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M components/mus/ws/window_tree_unittest.cc View 6 chunks +9 lines, -8 lines 0 comments Download
M content/renderer/mus/compositor_mus_connection.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/mus/compositor_mus_connection_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mash/app_driver/app_driver.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M ui/events/mojo/BUILD.gn View 2 chunks +3 lines, -1 line 0 comments Download
A + ui/events/mojo/event.mojom View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/events/mojo/event.typemap View 2 chunks +2 lines, -2 lines 0 comments Download
A + ui/events/mojo/event_constants.mojom View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/mojo/event_struct_traits.h View 1 2 chunks +10 lines, -10 lines 0 comments Download
M ui/events/mojo/event_struct_traits.cc View 1 2 3 11 chunks +68 lines, -69 lines 0 comments Download
A + ui/events/mojo/keyboard_codes.mojom View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/mojo/traits_test_service.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/mus/window_manager_connection.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
Hadi
PTAL.
4 years, 6 months ago (2016-06-09 21:17:13 UTC) #4
James Cook
LGTM assuming the build failures aren't anything serious. I'm happy to see Event now living ...
4 years, 6 months ago (2016-06-09 21:36:04 UTC) #5
Hadi
Fixed the trybot errors. PTAL. Adding palmer@ for mus/public/interfaces. Thanks.
4 years, 6 months ago (2016-06-10 17:06:18 UTC) #7
James Cook
still lgtm
4 years, 6 months ago (2016-06-10 17:59:09 UTC) #8
palmer
lgtm
4 years, 6 months ago (2016-06-10 18:58:55 UTC) #9
Ben Goodger (Google)
lgtm
4 years, 6 months ago (2016-06-13 14:13:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057793002/60001
4 years, 6 months ago (2016-06-13 14:16:44 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-13 15:33:09 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 15:33:41 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 15:34:43 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b1637da1d27e0a28a16c1c6954c97f94111cd448
Cr-Commit-Position: refs/heads/master@{#399454}

Powered by Google App Engine
This is Rietveld 408576698