Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2057743002: Enable Spitzer for Android Webview (Closed)

Created:
4 years, 6 months ago by Tima Vaisburd
Modified:
4 years, 5 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org, sgurun-gerrit only, watk
Base URL:
https://chromium.googlesource.com/chromium/src.git@spitzer-aw-disable-tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable Spitzer for Android Webview The CL removes the command line flag that disabled it. BUG=597495 Committed: https://crrev.com/e0e5c818737bb30a4526245db6ef32d9c6a8ef5e Cr-Commit-Position: refs/heads/master@{#403031}

Patch Set 1 #

Patch Set 2 : Changed CL dependency order, now it depends on COPY_REQUIRED #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M android_webview/lib/main/aw_main_delegate.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Tima Vaisburd
I spit the original CL in 3 parts: 1. Disable the AW tests that rely ...
4 years, 6 months ago (2016-06-09 20:17:30 UTC) #2
liberato (no reviews please)
On 2016/06/09 20:17:30, Tima Vaisburd wrote: > I spit the original CL in 3 parts: ...
4 years, 6 months ago (2016-06-09 20:31:49 UTC) #3
boliu
On 2016/06/09 20:31:49, liberato wrote: > On 2016/06/09 20:17:30, Tima Vaisburd wrote: > > I ...
4 years, 6 months ago (2016-06-09 20:34:33 UTC) #4
Tima Vaisburd
PTAL.
4 years, 5 months ago (2016-06-29 22:42:29 UTC) #6
boliu
lgtm
4 years, 5 months ago (2016-06-29 22:46:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2057743002/40001
4 years, 5 months ago (2016-06-29 23:39:41 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-30 00:33:20 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 00:33:23 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 00:35:56 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e0e5c818737bb30a4526245db6ef32d9c6a8ef5e
Cr-Commit-Position: refs/heads/master@{#403031}

Powered by Google App Engine
This is Rietveld 408576698