Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issue 2057733002: 🍴 Store last saved tab metadata to avoid resaving. (Closed)

Created:
4 years, 6 months ago by Peter Wen
Modified:
4 years, 6 months ago
Reviewers:
gone, Steven Holte
CC:
chromium-reviews, Theresa
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Store last saved tab metadata to avoid resaving. - Do not re-save to disk if new metadata is the same as the old. - Add stats to determine where saveState is spending most of its time. - Move to using uptimeMillis to avoid stats being influenced by time spent in sleep. BUG=612574 Committed: https://crrev.com/6a48a177e5b82fa730438097673c61ca24c9af29 Cr-Commit-Position: refs/heads/master@{#400665}

Patch Set 1 #

Patch Set 2 : Add more UMA stats. #

Total comments: 6

Patch Set 3 : Add histogram for array length. #

Total comments: 2

Patch Set 4 : ) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -9 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java View 1 2 3 12 chunks +21 lines, -9 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Peter Wen
This will increase memory usage (by a couple KB depending on how many tabs are ...
4 years, 6 months ago (2016-06-13 20:55:51 UTC) #2
gone
https://codereview.chromium.org/2057733002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java File chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java (right): https://codereview.chromium.org/2057733002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java#newcode277 chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java:277: byte[] currentMetadata = serializeTabMetadata(); If we're already doing this, ...
4 years, 6 months ago (2016-06-14 17:11:32 UTC) #4
Peter Wen
cc+twellington for TPS metadata size FYI. https://codereview.chromium.org/2057733002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java File chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java (right): https://codereview.chromium.org/2057733002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java#newcode277 chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java:277: byte[] currentMetadata = ...
4 years, 6 months ago (2016-06-14 18:18:03 UTC) #5
gone
lgtm https://codereview.chromium.org/2057733002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java File chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java (right): https://codereview.chromium.org/2057733002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java#newcode278 chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java:278: if (!Arrays.equals(mLastSavedMetadata, currentMetadata)) { On 2016/06/14 18:18:03, Peter ...
4 years, 6 months ago (2016-06-14 20:20:59 UTC) #6
Peter Wen
+holte@ for histogram OWNERS, one new histogram for file sizes and two for timing. https://codereview.chromium.org/2057733002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java ...
4 years, 6 months ago (2016-06-14 20:46:34 UTC) #8
Peter Wen
@holte - friendly ping. 🎀
4 years, 6 months ago (2016-06-16 15:26:34 UTC) #9
Steven Holte
On 2016/06/16 15:26:34, Peter Wen wrote: > @holte - friendly ping. 🎀 lgtm
4 years, 6 months ago (2016-06-16 22:37:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057733002/60001
4 years, 6 months ago (2016-06-20 12:17:15 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-20 13:13:00 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 13:14:48 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6a48a177e5b82fa730438097673c61ca24c9af29
Cr-Commit-Position: refs/heads/master@{#400665}

Powered by Google App Engine
This is Rietveld 408576698