Fix GrDrawContextPriv::stencilRect

Fix GrDrawContextPriv::stencilRect

Updates stencilRect to not call getFillRectBatch. This method can
return a batch that uses coverage AA, which isn't appropriate for
stencil draws.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2057613003

Committed: https://skia.googlesource.com/skia/+/656dbe4c712d2016dcf9af903f088f34ad2bf94d

[csmartdalton, 2016-06-09 20:43:53]

Description was changed from

==========
Fix GrDrawContextPriv::stencilRect

Updates stencilRect to not call getFillRectBatch. This method can
return a batch that uses coverage AA, which isn't  appropriate for
stencil draws.

BUG=skia:
==========

to

==========
Fix GrDrawContextPriv::stencilRect

Updates stencilRect to not call getFillRectBatch. This method can
return a batch that uses coverage AA, which isn't  appropriate for
stencil draws.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2057613003
==========

[csmartdalton, 2016-06-09 20:44:31]

Description was changed from

==========
Fix GrDrawContextPriv::stencilRect

Updates stencilRect to not call getFillRectBatch. This method can
return a batch that uses coverage AA, which isn't  appropriate for
stencil draws.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2057613003
==========

to

==========
Fix GrDrawContextPriv::stencilRect

Updates stencilRect to not call getFillRectBatch. This method can
return a batch that uses coverage AA, which isn't appropriate for
stencil draws.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2057613003
==========

[csmartdalton, 2016-06-09 20:46:46]

csmartdalton@google.com changed reviewers:
+ bsalomon@google.com

[bsalomon, 2016-06-09 20:49:20]

lgtm

[csmartdalton, 2016-06-09 21:27:12]

I think this take is more in the spirit of GrDrawContext

[bsalomon, 2016-06-10 00:21:13]

https://codereview.chromium.org/2057613003/diff/20001/src/gpu/GrDrawContext.cpp
File src/gpu/GrDrawContext.cpp (right):

https://codereview.chromium.org/2057613003/diff/20001/src/gpu/GrDrawContext.c...
src/gpu/GrDrawContext.cpp:414: ASSERT_SINGLE_OWNER_PRIV
Should we assert or fail if doAA is true and the RT isn't multisampled? Also,
perhaps we should rename the param useMSAA? And maybe comment in the .h that
this can only aa if the rt is msaa?

[csmartdalton, 2016-06-10 02:43:38]

https://codereview.chromium.org/2057613003/diff/20001/src/gpu/GrDrawContext.cpp
File src/gpu/GrDrawContext.cpp (right):

https://codereview.chromium.org/2057613003/diff/20001/src/gpu/GrDrawContext.c...
src/gpu/GrDrawContext.cpp:414: ASSERT_SINGLE_OWNER_PRIV
On 2016/06/10 00:21:13, bsalomon wrote:
> Should we assert or fail if doAA is true and the RT isn't multisampled? Also,
> perhaps we should rename the param useMSAA? And maybe comment in the .h that
> this can only aa if the rt is msaa?

Done. Went with useHWAA to match GrPB and the other callsites in this file.

[bsalomon, 2016-06-10 19:11:44]

lgtm

[csmartdalton, 2016-06-10 19:13:34]

The CQ bit was checked by csmartdalton@google.com

[commit-bot: I haz the power, 2016-06-10 19:13:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2057613003/60001

[commit-bot: I haz the power, 2016-06-10 19:33:00]

Description was changed from

==========
Fix GrDrawContextPriv::stencilRect

Updates stencilRect to not call getFillRectBatch. This method can
return a batch that uses coverage AA, which isn't appropriate for
stencil draws.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2057613003
==========

to

==========
Fix GrDrawContextPriv::stencilRect

Updates stencilRect to not call getFillRectBatch. This method can
return a batch that uses coverage AA, which isn't appropriate for
stencil draws.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2057613003

Committed:
https://skia.googlesource.com/skia/+/656dbe4c712d2016dcf9af903f088f34ad2bf94d
==========

[commit-bot: I haz the power, 2016-06-10 19:33:01]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/656dbe4c712d2016dcf9af903f088f34ad2bf94d