Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: include/v8.h

Issue 2057613002: Cleanup after EmbedderHeapTracer api updates (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 07513aa820117b8442135e3b986c55d88192f3b3..666dd0e272c381678bd2b2cc88d7d74fe463a603 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -5447,15 +5447,8 @@ class V8_EXPORT EmbedderHeapTracer {
* Embedder is expected to store them in it's marking deque and trace
* reachable wrappers from them when asked by AdvanceTracing method.
*/
- // TODO(hlopko): Make pure virtual after migration
virtual void RegisterV8References(
- const std::vector<std::pair<void*, void*> >& internal_fields) {}
- /**
- * **Deprecated**
- */
- // TODO(hlopko): Remove after migration
- virtual void TraceWrappersFrom(
- const std::vector<std::pair<void*, void*> >& internal_fields) {}
+ const std::vector<std::pair<void*, void*> >& internal_fields) = 0;
/**
* V8 will call this method at the beginning of the gc cycle.
*/
@@ -5468,11 +5461,8 @@ class V8_EXPORT EmbedderHeapTracer {
*
* Returns true if there is still work to do.
*/
- // TODO(hlopko): Make pure virtual after migration
virtual bool AdvanceTracing(double deadline_in_ms,
- AdvanceTracingActions actions) {
- return false;
- }
+ AdvanceTracingActions actions) = 0;
/**
* V8 will call this method at the end of the gc cycle. Allocation is *not*
* allowed in the TraceEpilogue.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698