Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2057613002: Cleanup after EmbedderHeapTracer api updates (Closed)

Created:
4 years, 6 months ago by Marcel Hlopko
Modified:
4 years, 6 months ago
Reviewers:
ulan
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Cleanup after EmbedderHeapTracer api updates In order to update v8 api and still be able to build chromium, we had to keep code in suboptimal state. Now when chromium caught up, we can perform cleanup :) LOG=no BUG=468240 Committed: https://crrev.com/d5f758eed62907775851c943e8a60197d75a5588 Cr-Commit-Position: refs/heads/master@{#36933}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M include/v8.h View 2 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Marcel Hlopko
Ptal :)
4 years, 6 months ago (2016-06-09 14:45:01 UTC) #2
ulan
lgtm
4 years, 6 months ago (2016-06-13 13:55:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057613002/1
4 years, 6 months ago (2016-06-13 13:57:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 14:26:04 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 14:27:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5f758eed62907775851c943e8a60197d75a5588
Cr-Commit-Position: refs/heads/master@{#36933}

Powered by Google App Engine
This is Rietveld 408576698