Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issue 2057603002: mojom: Error if multiple native types are mapped to the same mojom type. (Closed)

Created:
4 years, 6 months ago by sadrul
Modified:
4 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojom: Error if multiple native types are mapped to the same mojom type. BUG=none Committed: https://crrev.com/bec8759f88be1a0f441e5b3aed540312ccff7aff Cr-Commit-Position: refs/heads/master@{#399564}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M mojo/public/tools/bindings/generate_type_mappings.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sadrul
mapping to multiple native-types is not actually allowed, right?
4 years, 6 months ago (2016-06-09 14:40:47 UTC) #2
Ken Rockot(use gerrit already)
Right, otherwise what would the generator emit for interface Foo { Frobinate(Bar bar) }; if ...
4 years, 6 months ago (2016-06-13 17:35:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057603002/1
4 years, 6 months ago (2016-06-13 19:23:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 22:00:30 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 22:00:48 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 22:01:44 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bec8759f88be1a0f441e5b3aed540312ccff7aff
Cr-Commit-Position: refs/heads/master@{#399564}

Powered by Google App Engine
This is Rietveld 408576698