Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2057543002: [runtime] Deprecate RUNTIME_ASSERT from internal ops. (Closed)

Created:
4 years, 6 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Deprecate RUNTIME_ASSERT from internal ops. This removes explicit uses of the RUNTIME_ASSERT macro from some runtime methods. The implicit ones in CONVERT_FOO_ARG_CHECKED will be addressed in a separate CL for all runtime modules at once. R=bmeurer@chromium.org BUG=v8:5066 Committed: https://crrev.com/08b7bc9d65a185632bd586f0c822810041f8fb4d Cr-Commit-Position: refs/heads/master@{#36869}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -25 lines) Patch
M src/runtime/runtime-internal.cc View 8 chunks +24 lines, -25 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Starzinger
4 years, 6 months ago (2016-06-09 13:58:52 UTC) #3
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-09 15:32:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057543002/1
4 years, 6 months ago (2016-06-09 15:32:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 15:35:04 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 15:35:31 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08b7bc9d65a185632bd586f0c822810041f8fb4d
Cr-Commit-Position: refs/heads/master@{#36869}

Powered by Google App Engine
This is Rietveld 408576698