components/safe_browsing_db/v4_update_protocol_manager.h - Issue 2057433002: Replace the old URL format for PVer4 requests with the new format.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/v4_update_protocol_manager.h

Issue 2057433002: Replace the old URL format for PVer4 requests with the new format. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move #include to *.cc and use forward declaration in .h Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/safe_browsing_db/v4_protocol_manager_util.cc ('K') | « components/safe_browsing_db/v4_protocol_manager_util_unittest.cc ('k') | components/safe_browsing_db/v4_update_protocol_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/safe_browsing_db/v4_update_protocol_manager.h

diff --git a/components/safe_browsing_db/v4_update_protocol_manager.h b/components/safe_browsing_db/v4_update_protocol_manager.h

index 92be60676f5990f9f83d7b5dfbaf7b5065d5425d..d9246e5825f93f9e6bf1780529fecc048474ec10 100644

--- a/components/safe_browsing_db/v4_update_protocol_manager.h

+++ b/components/safe_browsing_db/v4_update_protocol_manager.h

@@ -96,8 +96,10 @@ class V4UpdateProtocolManager : public net::URLFetcherDelegate,

// The method to generate the URL for the request to be sent to the server.

// |request_base64| is the base64 encoded form of an instance of the protobuf

- // FetchThreatListUpdatesRequest.

- GURL GetUpdateUrl(const std::string& request_base64) const;

+ // FetchThreatListUpdatesRequest. Also sets the appropriate header values for

+ // sending PVer4 requests in |headers|.

+ GURL GetUpdateUrlAndUpdateHeaders(const std::string& request_base64,

+ net::HttpRequestHeaders* headers) const;

// Fills a FetchThreatListUpdatesRequest protocol buffer for a request.

// Returns the serialized and base 64 encoded request as a string.