Source/core/rendering/RenderTheme.h - Issue 205743004: Expand system font values during font property parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderTheme.h

Issue 205743004: Expand system font values during font property parsing (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase and fix up unittest use of systemFont() Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderTheme.h

diff --git a/Source/core/rendering/RenderTheme.h b/Source/core/rendering/RenderTheme.h

index 8ecd33135b279ddc5e3f742703414a96925b5523..c25f2c1ed0e45ec6430ba26f0bb14ac5ee36d08b 100644

--- a/Source/core/rendering/RenderTheme.h

+++ b/Source/core/rendering/RenderTheme.h

@@ -146,7 +146,8 @@ public:

virtual double caretBlinkInterval() const { return 0.5; }

// System fonts and colors for CSS.

- virtual void systemFont(CSSValueID, FontDescription&) const = 0;

+ virtual void systemFont(CSSValueID systemFontID, FontStyle&, FontWeight&, float& fontSize, AtomicString& fontFamily) const = 0;

+ void systemFont(CSSValueID systemFontID, FontDescription&);

virtual Color systemColor(CSSValueID) const;

virtual int minimumMenuListSize(RenderStyle*) const { return 0; }