Expand system font values during font property parsing

Source/core/rendering/RenderTheme.h

 /*
  * This file is part of the theme implementation for form controls in WebCore.
  *
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Computer, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 128 matching lines @@
     Color focusRingColor() const;
     virtual Color platformFocusRingColor() const { return Color(0, 0, 0); }
     void setCustomFocusRingColor(const Color&);
     static Color tapHighlightColor();
     virtual Color platformTapHighlightColor() const { return RenderTheme::defaultTapHighlightColor; }
     virtual void platformColorsDidChange();
 
     virtual double caretBlinkInterval() const { return 0.5; }
 
     // System fonts and colors for CSS.
-    virtual void systemFont(CSSValueID, FontDescription&) const = 0;
+    virtual void systemFont(CSSValueID systemFontID, FontStyle&, FontWeight&, float& fontSize, AtomicString& fontFamily) const = 0;

[dglazkov, 2014/03/20 05:24:44]

I am curious why you cracked it open like that. Why not use FontDescription?

[alancutter (OOO until 2018), 2014/03/20 05:34:13]

Splitting the components out ensures the font style that the RenderThemes decide
upon maps cleanly to the font longhand properties, otherwise it's not clear
whether we're capturing the appropriate values off the FontDescription in the
CSSPropertyParser.

+    void systemFont(CSSValueID systemFontID, FontDescription&);
     virtual Color systemColor(CSSValueID) const;
 
     virtual int minimumMenuListSize(RenderStyle*) const { return 0; }
 
     virtual void adjustSliderThumbSize(RenderStyle*, Element*) const;
 
     virtual int popupInternalPaddingLeft(RenderStyle*) const { return 0; }
     virtual int popupInternalPaddingRight(RenderStyle*) const { return 0; }
     virtual int popupInternalPaddingTop(RenderStyle*) const { return 0; }
     virtual int popupInternalPaddingBottom(RenderStyle*) const { return 0; }
@@ skipping 152 matching lines @@
     static const RGBA32 defaultTapHighlightColor = 0x66000000;
 
 #if USE(NEW_THEME)
     Theme* m_platformTheme; // The platform-specific theme.
 #endif
 };
 
 } // namespace WebCore
 
 #endif // RenderTheme_h