Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: Source/core/css/resolver/StyleBuilderCustom.cpp

Issue 205743004: Expand system font values during font property parsing (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase and fix up unittest use of systemFont() Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/css/resolver/FontBuilder.cpp ('k') | Source/core/rendering/RenderTheme.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 5 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
7 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 7 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
8 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 8 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
9 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 9 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
10 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 10 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
(...skipping 1277 matching lines...) Expand 10 before | Expand all | Expand 10 after
1288 state.style()->setQuotes(quotes); 1288 state.style()->setQuotes(quotes);
1289 return; 1289 return;
1290 } 1290 }
1291 if (primitiveValue) { 1291 if (primitiveValue) {
1292 if (primitiveValue->getValueID() == CSSValueNone) 1292 if (primitiveValue->getValueID() == CSSValueNone)
1293 state.style()->setQuotes(QuotesData::create()); 1293 state.style()->setQuotes(QuotesData::create());
1294 } 1294 }
1295 return; 1295 return;
1296 // Shorthand properties. 1296 // Shorthand properties.
1297 case CSSPropertyFont: 1297 case CSSPropertyFont:
1298 // Only System Font identifiers should come through this method
1299 // all other values should have been handled when the shorthand
1300 // was expanded by the parser.
1301 // FIXME: System Font identifiers should not hijack this
1302 // short-hand CSSProperty like this.
1303 ASSERT(!isInitial);
1304 ASSERT(!isInherit);
1305 ASSERT(primitiveValue);
1306 state.style()->setLineHeight(RenderStyle::initialLineHeight());
1307 state.setLineHeightValue(0);
1308 state.fontBuilder().fromSystemFont(primitiveValue->getValueID(), state.s tyle()->effectiveZoom());
1309 return;
1310 case CSSPropertyAnimation: 1298 case CSSPropertyAnimation:
1311 case CSSPropertyBackground: 1299 case CSSPropertyBackground:
1312 case CSSPropertyBackgroundPosition: 1300 case CSSPropertyBackgroundPosition:
1313 case CSSPropertyBackgroundRepeat: 1301 case CSSPropertyBackgroundRepeat:
1314 case CSSPropertyBorder: 1302 case CSSPropertyBorder:
1315 case CSSPropertyBorderBottom: 1303 case CSSPropertyBorderBottom:
1316 case CSSPropertyBorderColor: 1304 case CSSPropertyBorderColor:
1317 case CSSPropertyBorderImage: 1305 case CSSPropertyBorderImage:
1318 case CSSPropertyBorderLeft: 1306 case CSSPropertyBorderLeft:
1319 case CSSPropertyBorderRadius: 1307 case CSSPropertyBorderRadius:
(...skipping 857 matching lines...) Expand 10 before | Expand all | Expand 10 after
2177 break; 2165 break;
2178 } 2166 }
2179 case CSSPropertyEnableBackground: 2167 case CSSPropertyEnableBackground:
2180 // Silently ignoring this property for now 2168 // Silently ignoring this property for now
2181 // http://bugs.webkit.org/show_bug.cgi?id=6022 2169 // http://bugs.webkit.org/show_bug.cgi?id=6022
2182 break; 2170 break;
2183 } 2171 }
2184 } 2172 }
2185 2173
2186 } // namespace WebCore 2174 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/css/resolver/FontBuilder.cpp ('k') | Source/core/rendering/RenderTheme.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698