Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(915)

Issue 2057423002: Fix CGdiDeviceDriver::DrawLine(). (Closed)

Created:
4 years, 3 months ago by Lei Zhang
Modified:
4 years, 3 months ago
Reviewers:
caryclark
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix CGdiDeviceDriver::DrawLine(). - Do the bounds check before applying the transformation. - Simplify the bounds check. - Fix nits. - Remove some nearby dead code. BUG=108144 Committed: https://pdfium.googlesource.com/pdfium/+/993d817e5e500f281baf37c4027e0f7b0bac7998

Patch Set 1 : I see dead code #

Patch Set 2 : Fix check, simplify check, fix nits #

Patch Set 3 : Do transform at the end #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -45 lines) Patch
M core/fxge/win32/fx_win32_device.cpp View 1 2 5 chunks +23 lines, -41 lines 0 comments Download
M core/fxge/win32/win32_int.h View 1 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Lei Zhang
See my update on the bug tracker about where this stands: https://bugs.chromium.org/p/chromium/issues/detail?id=108144#c41
4 years, 3 months ago (2016-06-11 02:34:11 UTC) #2
caryclark
lgtm
4 years, 3 months ago (2016-06-13 12:56:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057423002/40001
4 years, 3 months ago (2016-06-13 17:40:55 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-06-13 17:52:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/993d817e5e500f281baf37c4027e0f7b0bac...

Powered by Google App Engine
This is Rietveld 408576698