Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2057413002: Revert of [PCv2] Add tracing category needed for computing ttfmp (Closed)

Created:
4 years, 6 months ago by fmeawad
Modified:
4 years, 6 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [PCv2] Add tracing category needed for computing ttfmp (patchset #3 id:40001 of https://codereview.chromium.org/2049593002/ ) Reason for revert: Speculative revert, suspecting crashing the reference test page_cycler_v2.typical_25.reference on mac. BUG=619254 Original issue's description: > [PCv2] Add tracing category needed for computing ttfmp > > The time-to-first-meaningful-paint computation requires extra tracing categories to be enabled. > This CL enables recording of the category in PCv2. > > https://github.com/catapult-project/catapult/blob/master/tracing/tracing/metrics/system_health/first_paint_metric.html > > BUG=None > > Committed: https://crrev.com/f9bc2493524f028607a8755c5bcfd8f51ba17998 > Cr-Commit-Position: refs/heads/master@{#399186} TBR=nednguyen@google.com,ksakamoto@chromium.org,kouhei@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/a0777d3adce51c721375b8f1dfd71bb002911d1c Cr-Commit-Position: refs/heads/master@{#399342}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M tools/perf/benchmarks/page_cycler_v2.py View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
fmeawad
Created Revert of [PCv2] Add tracing category needed for computing ttfmp
4 years, 6 months ago (2016-06-11 01:04:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057413002/1
4 years, 6 months ago (2016-06-11 01:04:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-11 01:05:12 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-11 01:06:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0777d3adce51c721375b8f1dfd71bb002911d1c
Cr-Commit-Position: refs/heads/master@{#399342}

Powered by Google App Engine
This is Rietveld 408576698