Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Unified Diff: src/typing-asm.cc

Issue 2057403003: Hooking up asm-wasm conversion. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/typing-asm.cc
diff --git a/src/typing-asm.cc b/src/typing-asm.cc
index db1f8bdb60e39ebaa72ef630ce7faf70ec760e9a..d5adfa60511667cdcc4eb8e83251139f328177fd 100644
--- a/src/typing-asm.cc
+++ b/src/typing-asm.cc
@@ -44,6 +44,7 @@ AsmTyper::AsmTyper(Isolate* isolate, Zone* zone, Script* script,
root_(root),
valid_(true),
allow_simd_(false),
+ fixed_signature_(false),
property_info_(nullptr),
intish_(0),
stdlib_types_(zone),
@@ -86,6 +87,11 @@ void AsmTyper::VisitAsmModule(FunctionLiteral* fun) {
if (!use_asm_literal->raw_value()->AsString()->IsOneByteEqualTo("use asm"))
FAIL(fun, "missing \"use asm\"");
+ // TODO(bradnelson): Generalize this.
+ if (fixed_signature_ && scope->num_parameters() != 3) {
+ FAIL(fun, "only 3 parameter modules supported");
Mircea Trofin 2016/06/30 23:23:29 what's a 3-parameter module?
bradn 2016/07/01 01:06:08 Clarified.
+ }
+
// Module parameters.
for (int i = 0; i < scope->num_parameters(); ++i) {
Variable* param = scope->parameter(i);

Powered by Google App Engine
This is Rietveld 408576698