Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: src/builtins.h

Issue 2057403003: Hooking up asm-wasm conversion. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/bootstrapper.cc ('k') | src/builtins.cc » ('j') | src/builtins.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins.h
diff --git a/src/builtins.h b/src/builtins.h
index f99e05aa2a1bd2874ee9640e5da4ef740341e196..0db1a15c113ae7906b60cdd95a5d5a44e7dd03f9 100644
--- a/src/builtins.h
+++ b/src/builtins.h
@@ -177,8 +177,16 @@ class CodeStubAssembler;
V(RestrictedFunctionPropertiesThrower) \
V(RestrictedStrictArgumentsPropertiesThrower)
+// TODO(bradnelson): Implement for all arches and drop.
+#if defined(V8_TARGET_ARCH_X64)
Michael Starzinger 2016/06/29 08:29:23 We usually implement new features on all architect
bradn 2016/06/30 07:59:36 Done.
+#define BUILTIN_LIST_A_PARTIAL(V) V(InstantiateAsmJs, BUILTIN, kNoExtraICState)
+#else
+#define BUILTIN_LIST_A_PARTIAL(V)
+#endif
+
// Define list of builtins implemented in assembly.
#define BUILTIN_LIST_A(V) \
+ BUILTIN_LIST_A_PARTIAL(V) \
V(AllocateInNewSpace, BUILTIN, kNoExtraICState) \
V(AllocateInOldSpace, BUILTIN, kNoExtraICState) \
\
@@ -397,7 +405,7 @@ class Builtins {
#define DEF_ENUM_C(name) c_##name,
BUILTIN_LIST_C(DEF_ENUM_C)
#undef DEF_ENUM_C
- cfunction_count
+ cfunction_count
};
#define DECLARE_BUILTIN_ACCESSOR_C(name) Handle<Code> name();
@@ -470,6 +478,10 @@ class Builtins {
static void Generate_AllocateInOldSpace(MacroAssembler* masm);
static void Generate_ConstructedNonConstructable(MacroAssembler* masm);
static void Generate_CompileLazy(MacroAssembler* masm);
+#if defined(V8_TARGET_ARCH_X64)
Michael Starzinger 2016/06/29 08:29:23 Likewise.
bradn 2016/06/30 07:59:36 Done.
+ // TODO(bradnelson): Implement on all arches.
+ static void Generate_InstantiateAsmJs(MacroAssembler* masm);
Michael Starzinger 2016/06/29 08:29:23 nit: Can we move this declaration up one line? The
bradn 2016/06/30 07:59:36 Done.
+#endif
static void Generate_CompileBaseline(MacroAssembler* masm);
static void Generate_InOptimizationQueue(MacroAssembler* masm);
static void Generate_CompileOptimized(MacroAssembler* masm);
« no previous file with comments | « src/bootstrapper.cc ('k') | src/builtins.cc » ('j') | src/builtins.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698