DDC changes for Analyzer src/task/strong/info.dart refactor

lib/src/compiler/reify_coercions.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:analyzer/analyzer.dart' as analyzer;
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/element/type.dart' show DartType;
 import 'package:analyzer/src/dart/ast/ast.dart' show FunctionBodyImpl;
 import 'package:analyzer/src/dart/ast/utilities.dart' show NodeReplacer;
 import 'package:analyzer/src/dart/element/type.dart' show DynamicTypeImpl;
 import 'package:analyzer/src/generated/parser.dart' show ResolutionCopier;
-import 'package:analyzer/src/task/strong/info.dart'
-    show CoercionInfo, DownCast, DynamicInvoke;
+import 'package:analyzer/src/task/strong/ast_properties.dart' as ast_properties;
 import 'package:logging/logging.dart' as logger;
 
 import 'ast_builder.dart' show AstBuilder, RawAstBuilder;
 import 'element_helpers.dart' show isInlineJS;
 
 final _log = new logger.Logger('dev_compiler.reify_coercions');
 
 // This class implements a pass which modifies (in place) the ast replacing
 // abstract coercion nodes with their dart implementations.
 class CoercionReifier extends analyzer.GeneralizingAstVisitor<Object> {
   final cloner = new _TreeCloner();
 
   CoercionReifier._();
 
   /// Transforms the given compilation units, and returns a new AST with
   /// explicit coercion nodes in appropriate places.
   static List<CompilationUnit> reify(List<CompilationUnit> units) {
     var cr = new CoercionReifier._();
-    // Clone compilation units, so we don't modify the originals.
-    units = units.map(cr._clone).toList(growable: false);
-    units.forEach(cr.visitCompilationUnit);
-    return units;
+    return units.map(cr.visitCompilationUnit).toList(growable: false);
+  }
+
+  @override
+  CompilationUnit visitCompilationUnit(CompilationUnit node) {
+    if (ast_properties.hasImplicitCasts(node)) {
+      // Clone compilation unit, so we don't modify the originals.
+      node = _clone(node);
+      super.visitCompilationUnit(node);
+    }
+    return node;
   }
 
   @override
   visitExpression(Expression node) {
-    var coercion = CoercionInfo.get(node);
-    if (coercion is DownCast) {
-      return _visitDownCast(coercion, node);
+    node.visitChildren(this);
+
+    var castType = ast_properties.getImplicitCast(node);
+    if (castType != null) {
+      _replaceNode(node.parent, node, _castExpression(node, castType));
     }
-    return super.visitExpression(node);
   }
 
   @override
+  visitMethodInvocation(MethodInvocation node) {
+    if (isInlineJS(node.methodName.staticElement)) {
+      // Don't cast our inline-JS code in SDK.
+      ast_properties.setImplicitCast(node, null);
+    }
+    visitExpression(node);
+  }
+
+  @override
   visitParenthesizedExpression(ParenthesizedExpression node) {
     super.visitParenthesizedExpression(node);
     node.staticType = node.expression.staticType;
   }
 
   @override
   visitForEachStatement(ForEachStatement node) {
     // Visit other children.
     node.iterable.accept(this);
     node.body.accept(this);
 
     // If needed, assert a cast inside the body before the variable is read.
     var variable = node.identifier ?? node.loopVariable.identifier;
-    var coercion = CoercionInfo.get(variable);
-    if (coercion is DownCast) {
+    var castType = ast_properties.getImplicitCast(variable);
+    if (castType != null) {
       // Build the cast. We will place this cast in the body, so need to clone
       // the variable's AST node and clear out its static type (otherwise we
       // will optimize away the cast).
       var cast = _castExpression(
-          _clone(variable)..staticType = DynamicTypeImpl.instance,
-          coercion.convertedType);
+          _clone(variable)..staticType = DynamicTypeImpl.instance, castType);
 
       var body = node.body;
       var blockBody = <Statement>[RawAstBuilder.expressionStatement(cast)];
       if (body is Block) {
         blockBody.addAll(body.statements);
       } else {
         blockBody.add(body);
       }
       _replaceNode(node, body, RawAstBuilder.block(blockBody));
     }
   }
 
-  void _visitDownCast(DownCast node, Expression expr) {
-    expr.visitChildren(this);
-    _replaceNode(expr.parent, expr, coerceExpression(expr, node));
-  }
-
   void _replaceNode(AstNode parent, AstNode oldNode, AstNode newNode) {
     if (!identical(oldNode, newNode)) {
       var replaced = parent.accept(new NodeReplacer(oldNode, newNode));
       // It looks like NodeReplacer will always return true.
       // It does throw IllegalArgumentException though, if child is not found.
       assert(replaced);
     }
   }
 
-  /// Coerce [e] using [c], returning a new expression.
-  Expression coerceExpression(Expression e, DownCast node) {
-    if (e is NamedExpression) {
-      Expression inner = coerceExpression(e.expression, node);
-      return new NamedExpression(e.name, inner);
-    }
-    if (e is MethodInvocation && isInlineJS(e.methodName.staticElement)) {
-      // Inline JS code should not need casts.
-      return e;
-    }
-    return _castExpression(e, node.convertedType);
-  }
-
   Expression _castExpression(Expression e, DartType toType) {
     // We use an empty name in the AST, because the JS code generator only cares
     // about the target type. It does not look at the AST name.
     var typeName = new TypeName(AstBuilder.identifierFromString(''), null);
     typeName.type = toType;
     var cast = AstBuilder.asExpression(e, typeName);
     cast.staticType = toType;
     return cast;
   }
 
   /*=T*/ _clone/*<T extends AstNode>*/(/*=T*/ node) {
     var copy = node.accept(cloner) as dynamic/*=T*/;
     ResolutionCopier.copyResolutionData(node, copy);
     return copy;
   }
 }
 
 class _TreeCloner extends analyzer.AstCloner {
   void _cloneProperties(AstNode clone, AstNode node) {
-    if (clone != null) {
-      CoercionInfo.set(clone, CoercionInfo.get(node));
-      DynamicInvoke.set(clone, DynamicInvoke.get(node));
+    if (clone is Expression) {
+      ast_properties.setImplicitCast(
+          clone, ast_properties.getImplicitCast(node));
+      ast_properties.setIsDynamicInvoke(
+          clone, ast_properties.isDynamicInvoke(node));
     }
   }
 
   @override
   /*=E*/ cloneNode/*<E extends AstNode>*/(/*=E*/ node) {
     var clone = super.cloneNode(node);
     _cloneProperties(clone, node);
     return clone;
   }
 
@@ skipping 26 matching lines @@
 
   // TODO(jmesserly): workaround for
   // https://github.com/dart-lang/sdk/issues/26368
   @override
   TypeName visitTypeName(TypeName node) {
     var clone = super.visitTypeName(node);
     clone.type = node.type;
     return clone;
   }
 }