Issue 2057373003: DDC changes for Analyzer src/task/strong/info.dart refactor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2057373003: DDC changes for Analyzer src/task/strong/info.dart refactor (Closed)

Created:
4 years, 6 months ago by Jennifer Messerly

Modified:
4 years, 6 months ago

Reviewers:
Leaf

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

DDC changes for Analyzer src/task/strong/info.dart refactor landed in https://github.com/dart-lang/dev_compiler/commit/dd62f3015302942f8b23261060b2543df2a7bbd9

Patch Set 1 #

Total comments: 1

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -63 lines)			Patch
M	lib/src/compiler/code_generator.dart	View	8 chunks	+9 lines, -8 lines	0 comments	Download
M	lib/src/compiler/reify_coercions.dart	View	6 chunks	+34 lines, -35 lines	0 comments	Download
M	pubspec.lock	View	8 chunks	+17 lines, -17 lines	0 comments	Download
M	pubspec.yaml	View	1 chunk	+2 lines, -3 lines	1 comment	Download

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jennifer Messerly

https://codereview.chromium.org/2057373003/diff/1/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/2057373003/diff/1/pubspec.yaml#newcode33 pubspec.yaml:33: analyzer: { path: ../dart/sdk/pkg/analyzer } naturally, will need to ...

4 years, 6 months ago (2016-06-10 23:15:18 UTC) #1

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages