WebUI: cr-search-field, do not call delegate if search query did not change.

WebUI: cr-search-field, do not call delegate if search query did not change.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
BUG=608535
Committed: https://crrev.com/8cecfb55a718e2336332af555f41bdc8041c2391
Cr-Commit-Position: refs/heads/master@{#399750}

[dpapad, 2016-06-10 20:37:04]

Description was changed from

==========
WebUI: cr-search-field, do nothing if search query did not change, WIP.
==========

to

==========
WebUI: cr-search-field, do nothing if search query did not change, WIP.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-06-11 00:10:32]

Description was changed from

==========
WebUI: cr-search-field, do nothing if search query did not change, WIP.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
WebUI: cr-search-field, do nothing if search query did not change.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-06-11 00:19:52]

Description was changed from

==========
WebUI: cr-search-field, do nothing if search query did not change.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
WebUI: cr-search-field, do nothing if search query did not change.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-06-11 00:28:47]

Description was changed from

==========
WebUI: cr-search-field, do nothing if search query did not change.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
WebUI: cr-search-field, do nothing if search query did not change.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
BUG=608535
==========

[dpapad, 2016-06-11 00:29:16]

Description was changed from

==========
WebUI: cr-search-field, do nothing if search query did not change.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
BUG=608535
==========

to

==========
WebUI: cr-search-field, do not call delegate if search query did not change.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
BUG=608535
==========

[dpapad, 2016-06-13 21:54:03]

Patchset #1 (id:1) has been deleted

[dpapad, 2016-06-13 22:16:19]

dpapad@chromium.org changed reviewers:
+ tsergeant@chromium.org

[tsergeant, 2016-06-14 04:51:27]

lgtm

[Dan Beam, 2016-06-14 15:47:29]

nits

https://codereview.chromium.org/2057353002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/history_toolbar.js (right):

https://codereview.chromium.org/2057353002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/history_toolbar.js:100: * Update search
term.
just remove, maybe?

https://codereview.chromium.org/2057353002/diff/40001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js
(right):

https://codereview.chromium.org/2057353002/diff/40001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js:83:
var newValue = this.getValue();
var newValue = this.getValue();
if (newValue == this.lastValue_)
  return;

...

[dpapad, 2016-06-14 17:21:50]

https://codereview.chromium.org/2057353002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/history_toolbar.js (right):

https://codereview.chromium.org/2057353002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/history_toolbar.js:100: * Update search
term.
On 2016/06/14 at 15:47:29, Dan Beam wrote:
> just remove, maybe?

Done.

https://codereview.chromium.org/2057353002/diff/40001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js
(right):

https://codereview.chromium.org/2057353002/diff/40001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js:83:
var newValue = this.getValue();
On 2016/06/14 at 15:47:29, Dan Beam wrote:
> var newValue = this.getValue();
> if (newValue == this.lastValue_)
>   return;
> 
> ...

Done.

[dpapad, 2016-06-14 17:24:15]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-06-14 17:24:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2057353002/#ps60001
(title: "Addressing comments.")

[commit-bot: I haz the power, 2016-06-14 17:25:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2057353002/60001

[commit-bot: I haz the power, 2016-06-14 18:19:08]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-06-14 18:19:10]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-14 18:21:40]

Description was changed from

==========
WebUI: cr-search-field, do not call delegate if search query did not change.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
BUG=608535
==========

to

==========
WebUI: cr-search-field, do not call delegate if search query did not change.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
BUG=608535

Committed: https://crrev.com/8cecfb55a718e2336332af555f41bdc8041c2391
Cr-Commit-Position: refs/heads/master@{#399750}
==========

[commit-bot: I haz the power, 2016-06-14 18:21:41]

Patchset 3 (id:??) landed as
https://crrev.com/8cecfb55a718e2336332af555f41bdc8041c2391
Cr-Commit-Position: refs/heads/master@{#399750}