Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2057353002: WebUI: cr-search-field, do not call delegate if search query did not change. (Closed)

Created:
4 years, 6 months ago by dpapad
Modified:
4 years, 6 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, dbeam+watch-elements_chromium.org, michaelpg+watch-elements_chromium.org, oshima+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: cr-search-field, do not call delegate if search query did not change. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation BUG=608535 Committed: https://crrev.com/8cecfb55a718e2336332af555f41bdc8041c2391 Cr-Commit-Position: refs/heads/master@{#399750}

Patch Set 1 : Updating test. #

Patch Set 2 : Remove unneeded check. #

Total comments: 4

Patch Set 3 : Addressing comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -9 lines) Patch
M chrome/browser/resources/md_history/history_toolbar.js View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/test/data/webui/cr_elements/cr_toolbar_search_field_tests.js View 1 chunk +8 lines, -4 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js View 1 2 2 chunks +13 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (10 generated)
dpapad
4 years, 6 months ago (2016-06-13 22:16:19 UTC) #8
tsergeant
lgtm
4 years, 6 months ago (2016-06-14 04:51:27 UTC) #9
Dan Beam
nits https://codereview.chromium.org/2057353002/diff/40001/chrome/browser/resources/md_history/history_toolbar.js File chrome/browser/resources/md_history/history_toolbar.js (right): https://codereview.chromium.org/2057353002/diff/40001/chrome/browser/resources/md_history/history_toolbar.js#newcode100 chrome/browser/resources/md_history/history_toolbar.js:100: * Update search term. just remove, maybe? https://codereview.chromium.org/2057353002/diff/40001/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js ...
4 years, 6 months ago (2016-06-14 15:47:29 UTC) #10
dpapad
https://codereview.chromium.org/2057353002/diff/40001/chrome/browser/resources/md_history/history_toolbar.js File chrome/browser/resources/md_history/history_toolbar.js (right): https://codereview.chromium.org/2057353002/diff/40001/chrome/browser/resources/md_history/history_toolbar.js#newcode100 chrome/browser/resources/md_history/history_toolbar.js:100: * Update search term. On 2016/06/14 at 15:47:29, Dan ...
4 years, 6 months ago (2016-06-14 17:21:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057353002/60001
4 years, 6 months ago (2016-06-14 17:25:07 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 6 months ago (2016-06-14 18:19:08 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-14 18:19:10 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 18:21:41 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8cecfb55a718e2336332af555f41bdc8041c2391
Cr-Commit-Position: refs/heads/master@{#399750}

Powered by Google App Engine
This is Rietveld 408576698