Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2057333002: X11: Wait for UnmapNotify before trying to remap (Closed)

Created:
4 years, 6 months ago by Tom (Use chromium acct)
Modified:
4 years, 6 months ago
CC:
chromium-reviews, tfarina, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

X11: Wait for UnmapNotify before trying to remap A speculative fix for a suspected race condition in which we wait for a MapNotify that will never come. BUG=381732 Committed: https://crrev.com/89f356e5bb13b81624a432a149d18e75694676c9 Cr-Commit-Position: refs/heads/master@{#399484}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -9 lines) Patch
M ui/events/platform/x11/x11_event_source.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/events/platform/x11/x11_event_source.cc View 2 chunks +15 lines, -7 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 4 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057333002/1
4 years, 6 months ago (2016-06-10 19:30:03 UTC) #2
Tom (Use chromium acct)
4 years, 6 months ago (2016-06-10 19:30:04 UTC) #4
Elliot Glaysher
lgtm I like how you don't block waiting for an unmap until the next map.
4 years, 6 months ago (2016-06-10 19:46:11 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-10 20:17:39 UTC) #7
sadrul
It would be nice to finally add some test coverage for all of this. lgtm
4 years, 6 months ago (2016-06-13 15:33:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057333002/1
4 years, 6 months ago (2016-06-13 17:19:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 18:11:52 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 18:13:20 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/89f356e5bb13b81624a432a149d18e75694676c9
Cr-Commit-Position: refs/heads/master@{#399484}

Powered by Google App Engine
This is Rietveld 408576698