Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2057293002: Implement SkFontMgr_Custom::onCreateFromFontData. (Closed)

Created:
4 years, 6 months ago by bungeman-skia
Modified:
4 years, 6 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Implement SkFontMgr_Custom::onCreateFromFontData. This fixes serialization issues. We could create a non-default gx typeface, but not deserialize it correctly. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2057293002 Committed: https://skia.googlesource.com/skia/+/57c948251a4ecde2dc1b6b7fbf13ac578ffba155

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix move. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M src/ports/SkFontMgr_custom.cpp View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057293002/1
4 years, 6 months ago (2016-06-10 18:31:21 UTC) #4
bungeman-skia
https://codereview.chromium.org/2057293002/diff/1/src/ports/SkFontMgr_custom.cpp File src/ports/SkFontMgr_custom.cpp (right): https://codereview.chromium.org/2057293002/diff/1/src/ports/SkFontMgr_custom.cpp#newcode303 src/ports/SkFontMgr_custom.cpp:303: std::unique_ptr<SkFontData> unique_data(data); Since no one outside Skia is using ...
4 years, 6 months ago (2016-06-10 18:32:11 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/9039) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on ...
4 years, 6 months ago (2016-06-10 18:33:52 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057293002/20001
4 years, 6 months ago (2016-06-10 19:21:05 UTC) #10
mtklein
lgtm
4 years, 6 months ago (2016-06-10 19:33:15 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-10 19:36:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057293002/20001
4 years, 6 months ago (2016-06-10 19:42:23 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 19:43:21 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/57c948251a4ecde2dc1b6b7fbf13ac578ffba155

Powered by Google App Engine
This is Rietveld 408576698