|
|
Created:
4 years, 6 months ago by bungeman-skia Modified:
4 years, 6 months ago Reviewers:
mtklein CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionImplement SkFontMgr_Custom::onCreateFromFontData.
This fixes serialization issues. We could create a non-default gx
typeface, but not deserialize it correctly.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2057293002
Committed: https://skia.googlesource.com/skia/+/57c948251a4ecde2dc1b6b7fbf13ac578ffba155
Patch Set 1 #
Total comments: 1
Patch Set 2 : Fix move. #Messages
Total messages: 17 (9 generated)
Description was changed from ========== Implement SkFontMgr_Custom::onCreateFromFontData. This fixes serialization issues. We could create a non-default gx typeface, but not deserialize it correctly. ========== to ========== Implement SkFontMgr_Custom::onCreateFromFontData. This fixes serialization issues. We could create a non-default gx typeface, but not deserialize it correctly. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2057293002 ==========
Description was changed from ========== Implement SkFontMgr_Custom::onCreateFromFontData. This fixes serialization issues. We could create a non-default gx typeface, but not deserialize it correctly. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2057293002 ========== to ========== Implement SkFontMgr_Custom::onCreateFromFontData. This fixes serialization issues. We could create a non-default gx typeface, but not deserialize it correctly. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2057293002 ==========
The CQ bit was checked by bungeman@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057293002/1
bungeman@google.com changed reviewers: + mtklein@google.com
https://codereview.chromium.org/2057293002/diff/1/src/ports/SkFontMgr_custom.cpp File src/ports/SkFontMgr_custom.cpp (right): https://codereview.chromium.org/2057293002/diff/1/src/ports/SkFontMgr_custom.... src/ports/SkFontMgr_custom.cpp:303: std::unique_ptr<SkFontData> unique_data(data); Since no one outside Skia is using this right now, the next CL is to update the interface to just take std::unique_ptr<SkFontData>.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...) Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)
The CQ bit was checked by bungeman@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057293002/20001
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057293002/20001
Message was sent while issue was closed.
Description was changed from ========== Implement SkFontMgr_Custom::onCreateFromFontData. This fixes serialization issues. We could create a non-default gx typeface, but not deserialize it correctly. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2057293002 ========== to ========== Implement SkFontMgr_Custom::onCreateFromFontData. This fixes serialization issues. We could create a non-default gx typeface, but not deserialize it correctly. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2057293002 Committed: https://skia.googlesource.com/skia/+/57c948251a4ecde2dc1b6b7fbf13ac578ffba155 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/57c948251a4ecde2dc1b6b7fbf13ac578ffba155 |