third_party/WebKit/Source/bindings/templates/partial_interface.h - Issue 2057273002: [OriginTrials] Support OriginTrialEnabled IDL attribute on constants

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/partial_interface.h

Issue 2057273002: [OriginTrials] Support OriginTrialEnabled IDL attribute on constants (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move signature creation out of for loop Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/interface_base.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/partial_interface.h

diff --git a/third_party/WebKit/Source/bindings/templates/partial_interface.h b/third_party/WebKit/Source/bindings/templates/partial_interface.h

index 512cf62539e4f1ae898d15d2a794ba42e543b073..cfe97763b877537e21e0926b7fb6441a478c36e4 100644

--- a/third_party/WebKit/Source/bindings/templates/partial_interface.h

+++ b/third_party/WebKit/Source/bindings/templates/partial_interface.h

@@ -28,8 +28,8 @@ public:

{% endfor %}

{# Custom internal fields #}

static void preparePrototypeAndInterfaceObject(v8::Local<v8::Context>, const DOMWrapperWorld&, v8::Local<v8::Object>, v8::Local<v8::Function>, v8::Local<v8::FunctionTemplate>);

- {% for group in attributes|origin_trial_enabled_attributes|groupby('origin_trial_feature_name') %}{{newline}}

- static void install{{group.grouper}}(ScriptState*, v8::Local<v8::Object> instance);

+ {% for origin_trial_feature_name in origin_trial_feature_names %}{{newline}}

+ static void install{{origin_trial_feature_name}}(ScriptState*, v8::Local<v8::Object> instance);

{% endfor %}

private:

static void install{{v8_class}}Template(v8::Isolate*, const DOMWrapperWorld&, v8::Local<v8::FunctionTemplate> interfaceTemplate);