third_party/WebKit/Source/bindings/templates/constants.cpp - Issue 2057273002: [OriginTrials] Support OriginTrialEnabled IDL attribute on constants

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/constants.cpp

Issue 2057273002: [OriginTrials] Support OriginTrialEnabled IDL attribute on constants (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move signature creation out of for loop Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_utilities.py ('k') | third_party/WebKit/Source/bindings/templates/interface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/constants.cpp

diff --git a/third_party/WebKit/Source/bindings/templates/constants.cpp b/third_party/WebKit/Source/bindings/templates/constants.cpp

index 1d7d1c1025690584e44475f311ca763ab5717e8a..c4d8e925e3de00070774ddb11f8e34ef954a53c8 100644

--- a/third_party/WebKit/Source/bindings/templates/constants.cpp

+++ b/third_party/WebKit/Source/bindings/templates/constants.cpp

@@ -40,7 +40,7 @@ V8DOMConfiguration::installConstant(isolate, interfaceTemplate, prototypeTemplat

{% endfor %}

{% endfilter %}

{% endfor %}

-{# Constants with [DeprecateAs] or [MeasureAs] or [OriginTrialEnabled] #}

+{# Constants with [DeprecateAs] or [MeasureAs] #}

{% for constant in constants | has_special_getter %}

V8DOMConfiguration::installConstantWithGetter(isolate, interfaceTemplate, prototypeTemplate, "{{constant.name}}", {{cpp_class}}V8Internal::{{constant.name}}ConstantGetterCallback);

{% endfor %}