third_party/WebKit/Source/core/testing/WorkerInternals.idl - Issue 2057273002: [OriginTrials] Support OriginTrialEnabled IDL attribute on constants

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/testing/WorkerInternals.idl

Issue 2057273002: [OriginTrials] Support OriginTrialEnabled IDL attribute on constants (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing comments from PS#2 Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/bindings/templates/interface_base.cpp ('K') | « third_party/WebKit/Source/core/origin_trials/testing/WorkerInternalsFrobulate.idl ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 interface WorkerInternals {	5 [

	6 DoNotCheckConstants
	Yuki 2016/06/16 08:01:08 Why do you need this extended attribute? This dis Why do you need this extended attribute? This disables tests about constant values. iclelland 2016/06/16 22:55:37 I don't, now that I discovered the [Reflect] IDL a Show quoted text On 2016/06/16 08:01:08, Yuki wrote: > Why do you need this extended attribute? This disables tests about constant > values. I don't, now that I discovered the [Reflect] IDL attribute. The trouble was that the constant I was adding would fail blink style checks, as it is all uppercase. DoNotCheckConstants is already present on the Internals interface, so I felt that adding it here was also justified.
	7 ] interface WorkerInternals {

6 };	8 };

OLD	NEW