[OriginTrials] Support OriginTrialEnabled IDL attribute on constants

third_party/WebKit/Source/bindings/templates/interface_base.cpp

 {% include 'copyright_block.txt' %}
 #include "{{v8_class_or_partial}}.h"
 
 {% for filename in cpp_includes if filename != '%s.h' % cpp_class_or_partial %}
 #include "{{filename}}"
 {% endfor %}
 
 namespace blink {
 {% set to_active_scriptwrappable = '%s::toActiveScriptWrappable' % v8_class
                                    if active_scriptwrappable else '0' %}
@@ skipping 347 matching lines @@
     {% endfilter %}
     {% endfor %}
     {% endif %}
 }
 
 {% endif %}{# not is_array_buffer_or_view #}
 {% endblock %}
 {##############################################################################}
 {% block origin_trials %}
 {% from 'attributes.cpp' import attribute_configuration with context %}
-{% for group in attributes|origin_trial_enabled_attributes|groupby('origin_trial_feature_name') %}{{newline}}
-void {{v8_class_or_partial}}::install{{group.grouper}}(ScriptState* scriptState, v8::Local<v8::Object> instance)
+{% from 'constants.cpp' import constant_configuration with context %}
+{% for origin_trial_feature_name in origin_trial_feature_names %}{{newline}}

[Yuki, 2016/06/13 06:47:55]

Do we really need this {{newline}}?

[iclelland, 2016/06/15 14:08:41]

It's not strictly needed for correctness, but it provides the expected blank
line between function definitions.

+void {{v8_class_or_partial}}::install{{origin_trial_feature_name}}(ScriptState* scriptState, v8::Local<v8::Object> instance)
 {
     v8::Local<v8::Object> prototype = instance->GetPrototype()->ToObject(scriptState->isolate());
     v8::Local<v8::Signature> signature;

[Yuki, 2016/06/13 06:47:55]

Passing the empty signature to V8DOMConfiguration::installAccessor() is really
dangerous.  You must pass the effective signature as follows.

    v8::Local<v8::Signature> signature = v8::Signature::New(isolate,
interfaceTemplate);

[iclelland, 2016/06/15 14:08:41]

Done.

     ALLOW_UNUSED_LOCAL(signature);
-    {% for attribute in group.list | unique_by('name') | sort %}
+    {# Origin-Trial-enabled attributes #}
+    {% for attribute in attributes|for_origin_trial_feature(origin_trial_feature_name) | unique_by('name') | sort %}

[Yuki, 2016/06/13 06:47:55]

Put spaces on the both sides of | operator to be consistent.

[iclelland, 2016/06/15 14:08:41]

Thanks, done.

     {% if attribute.is_data_type_property %}
     const V8DOMConfiguration::AttributeConfiguration attribute{{attribute.name}}Configuration = \
         {{attribute_configuration(attribute)}};
     V8DOMConfiguration::installAttribute(scriptState->isolate(), scriptState->world(), instance, prototype, attribute{{attribute.name}}Configuration);
     {% else %}
     const V8DOMConfiguration::AccessorConfiguration accessor{{attribute.name}}Configuration = \
         {{attribute_configuration(attribute)}};
     V8DOMConfiguration::installAccessor(scriptState->isolate(), scriptState->world(), instance, prototype, v8::Local<v8::Function>(), signature, accessor{{attribute.name}}Configuration);
     {% endif %}
     {% endfor %}
+
+    {# Origin-Trial-enabled constants #}
+    {% for constant in constants | for_origin_trial_feature(origin_trial_feature_name) | unique_by('name') | sort %}
+    {% set constant_name = constant.name.title().replace('_', '') %}
+    const V8DOMConfiguration::ConstantConfiguration constant{{constant_name}}Configuration = {{constant_configuration(constant)}};
+    V8DOMConfiguration::installConstant(scriptState->isolate(), scriptState->world(), prototype, constant{{constant_name}}Configuration);
+    {% endfor %}
 }
 {% endfor %}
 {% endblock %}
 {##############################################################################}
 {% block get_dom_template %}{% endblock %}
 {% block get_dom_template_for_named_properties_object %}{% endblock %}
 {% block has_instance %}{% endblock %}
 {% block to_impl %}{% endblock %}
 {% block to_impl_with_type_check %}{% endblock %}
 {% block install_conditional_attributes %}{% endblock %}
 {##############################################################################}
 {% block prepare_prototype_and_interface_object %}{% endblock %}
 {##############################################################################}
 {% block to_active_scriptwrappable %}{% endblock %}
 {% for method in methods if method.is_implemented_in_private_script and method.visible %}
 {{method_implemented_in_private_script(method)}}
 {% endfor %}
 {% for attribute in attributes if attribute.is_implemented_in_private_script %}
 {{attribute_getter_implemented_in_private_script(attribute)}}
 {% if attribute.has_setter %}
 {{attribute_setter_implemented_in_private_script(attribute)}}
 {% endif %}
 {% endfor %}
 {% block partial_interface %}{% endblock %}
 } // namespace blink