Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issue 2057263002: PPC: Move hashmap into src/base. (Closed)

Created:
4 years, 6 months ago by JaideepBajwa
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Move hashmap into src/base. Port 2fd55667a63a1428e9501336e5cd97f5431aa607 Original commit message: We ported hashmap.h into libsampler as a workaround before, so the main focus of this patch is to reduce code duplication. This patch moves the hashmap into src/base as well as creates DefaultAllocationPolicy using malloc and free. R=lpy@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:5050 LOG=N Committed: https://crrev.com/c7cddee678c8ac89ad4683c38253569bf677eb17 Cr-Commit-Position: refs/heads/master@{#36900}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -20 lines) Patch
M src/ppc/simulator-ppc.h View 4 chunks +6 lines, -8 lines 0 comments Download
M src/ppc/simulator-ppc.cc View 6 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 6 months ago (2016-06-10 17:24:25 UTC) #1
john.yan
lgtm
4 years, 6 months ago (2016-06-10 17:25:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057263002/1
4 years, 6 months ago (2016-06-10 17:26:39 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 17:53:54 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 17:54:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7cddee678c8ac89ad4683c38253569bf677eb17
Cr-Commit-Position: refs/heads/master@{#36900}

Powered by Google App Engine
This is Rietveld 408576698