Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1060)

Issue 2057253002: PPC: [stubs] Remove N-argument Hydrogen-based Array constructor stub (Closed)

Created:
4 years, 6 months ago by JaideepBajwa
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [stubs] Remove N-argument Hydrogen-based Array constructor stub Port c8ac0d8693f559795eeb3f3aaf386dde166fb2ab Original commit message: Instead, always tail call to the runtime. Also, cleanup the various versions of the runtime call that is used for Array construction fallback. There can be only one. R=danno@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=chromium:608675 LOG=N Committed: https://crrev.com/7f6f6ad1babd71e0b04314b3df387af44095bde3 Cr-Commit-Position: refs/heads/master@{#36901}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -77 lines) Patch
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 7 chunks +17 lines, -60 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
JaideepBajwa
PTAL
4 years, 6 months ago (2016-06-10 17:23:56 UTC) #1
john.yan
lgtm
4 years, 6 months ago (2016-06-10 17:28:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057253002/1
4 years, 6 months ago (2016-06-10 17:34:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 18:00:45 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 18:00:47 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 18:03:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f6f6ad1babd71e0b04314b3df387af44095bde3
Cr-Commit-Position: refs/heads/master@{#36901}

Powered by Google App Engine
This is Rietveld 408576698