LayoutTests/editing/selection/skip-over-contenteditable.html - Issue 20572005: Allow selection to skip over contenteditable

Side by Side Diff: LayoutTests/editing/selection/skip-over-contenteditable.html

Issue 20572005: Allow selection to skip over contenteditable (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | LayoutTests/editing/selection/skip-over-contenteditable-expected.txt » ('j') | LayoutTests/editing/selection/skip-over-uneditable-in-contenteditable.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <html>

	3 <body>

	4 <script src="../../fast/js/resources/js-test-pre.js"></script>

	5

	6 <p id="before">Before</p>

	7 <div contentEditable></div>

	8 <p id="after">After</p>

	9

	10 <div id="console"></div>

	11 <script>

	12 description("Ensure that extending a selection skips past a contentEditable.");

	13

	14 window.before = document.getElementById("before");
	yosin_UTC9 2013/08/31 01:00:47 nit: var before = ... nit: var before = ... yosin_UTC9 2013/08/31 01:00:47 nit: var before = ... nit: var before = ... dmazzoni 2013/09/05 07:57:29 Then I can't reference it in shouldBe, unless I'm Show quoted text On 2013/08/31 01:00:47, Yoshifumi Inoue wrote: > nit: var before = ... Then I can't reference it in shouldBe, unless I'm misunderstanding. yosin_UTC9 2013/09/05 08:42:48 <div id="foo">x</div> <script> var foo = document. Show quoted text On 2013/09/05 07:57:29, Dominic Mazzoni wrote: > On 2013/08/31 01:00:47, Yoshifumi Inoue wrote: > > nit: var before = ... > > Then I can't reference it in shouldBe, unless I'm misunderstanding. On my desktop, below script works: <div id="foo">x</div> <script> var foo = document.getElementById('foo'); shouldBeEqualToString('foo.textContent', 'x'); </script> dmazzoni 2013/09/05 17:17:21 You're right. I realized that the problem is only Show quoted text On 2013/09/05 08:42:48, Yoshifumi Inoue wrote: > On 2013/09/05 07:57:29, Dominic Mazzoni wrote: > > On 2013/08/31 01:00:47, Yoshifumi Inoue wrote: > > > nit: var before = ... > > > > Then I can't reference it in shouldBe, unless I'm misunderstanding. > > On my desktop, below script works: > <div id="foo">x</div> > <script> > var foo = document.getElementById('foo'); > shouldBeEqualToString('foo.textContent', 'x'); > </script> You're right. I realized that the problem is only when shouldBe is called inside a function, then it can't access variables that are local to that function. I originally had a function when I wrote this, but since there isn't one anymore, that isn't needed. Fixed.
	15 window.after = document.getElementById("after");
	yosin_UTC9 2013/08/31 01:00:47 nit: var after = nit: var after =
	16

	17 var sel = window.getSelection();

	18 sel.setBaseAndExtent(before, 0, before, 6);

	19 sel.modify("extend", "forward", "character");

	20 shouldBe("window.getSelection().focusNode == after", "true");
	yosin_UTC9 2013/08/31 01:00:47 You can write shouldBe("sel.focusNode", "after") You can write shouldBe("sel.focusNode", "after") dmazzoni 2013/09/05 07:57:29 This doesn't work unless "sel" is a global. As fa Show quoted text On 2013/08/31 01:00:47, Yoshifumi Inoue wrote: > You can write > shouldBe("sel.focusNode", "after") This doesn't work unless "sel" is a global. As far as I know I can do it one of two ways: 1. Make "before", "after", and "sel" into globals so that shouldBe can evaluate them 2. Use complete specifications inside shouldBe, for example: shouldBe("window.getSelection().focusNode == document.getElementById('after')", "true") yosin_UTC9 2013/09/05 08:42:48 eval() can see them. Here is working sample: http Show quoted text On 2013/09/05 07:57:29, Dominic Mazzoni wrote: > On 2013/08/31 01:00:47, Yoshifumi Inoue wrote: > > You can write > > shouldBe("sel.focusNode", "after") > > This doesn't work unless "sel" is a global. > > As far as I know I can do it one of two ways: > > 1. Make "before", "after", and "sel" into globals so that shouldBe can evaluate > them eval() can see them. Here is working sample: http://src.chromium.org/viewvc/blink/trunk/LayoutTests/editing/deleting/delet...
	21

	22 sel.setBaseAndExtent(after, 5, after, 0);

	23 sel.modify("extend", "backward", "character");

	24 shouldBe("window.getSelection().focusNode.parentElement == before", "true");
	yosin_UTC9 2013/08/31 01:00:47 You can write shouldBe("sel.focusNode.paretElement You can write shouldBe("sel.focusNode.paretElement", "before") dmazzoni 2013/09/05 17:17:21 Done. Show quoted text On 2013/08/31 01:00:47, Yoshifumi Inoue wrote: > You can write > shouldBe("sel.focusNode.paretElement", "before") Done.
	25 </script>

	26

	27 <script src="../../fast/js/resources/js-test-post.js"></script>

	28 </body>

	29 </html>

OLD	NEW