Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2057193004: Parser: Remove rest_parameter from STRING_CONSTANTS (Closed)

Created:
4 years, 6 months ago by gsathya
Modified:
4 years, 6 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Parser: Remove rest_parameter from STRING_CONSTANTS This is dead code. Committed: https://crrev.com/65c1eef8ebf34070c11cf93850e977b6bab81cf5 Cr-Commit-Position: refs/heads/master@{#36977}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/ast/ast-value-factory.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057193004/1
4 years, 6 months ago (2016-06-11 00:08:56 UTC) #2
gsathya
4 years, 6 months ago (2016-06-11 00:11:20 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-11 00:44:24 UTC) #7
Dan Ehrenberg
lgtm
4 years, 6 months ago (2016-06-11 00:56:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057193004/1
4 years, 6 months ago (2016-06-14 18:31:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 19:01:14 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 19:03:24 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/65c1eef8ebf34070c11cf93850e977b6bab81cf5
Cr-Commit-Position: refs/heads/master@{#36977}

Powered by Google App Engine
This is Rietveld 408576698