Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 2057193003: Reland of Flip Linux bots on chromium.lkgr to GN. (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke, brettw, inferno
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@flip_linux_memory_3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Flip Linux bots on chromium.lkgr to GN. (patchset #3 id:60001 of https://codereview.chromium.org/2054843002/ ) Reason for revert: This might work now (see https://crbug.com/618702, which I forgot to mention in the revert message). Original issue's description: > Revert of Flip Linux bots on chromium.lkgr to GN. (patchset #3 id:40001 of https://codereview.chromium.org/2006173002/ ) > > Reason for revert: > This had no effect: The LKGR waterfall used to be not on recipes, and mb wasn't hooked up right and in gn mode wrote its output to out/None (and runhooks still ran gyp, so gyp's ninja files were always used). > > I've now switched most of the bots to recipes, and now gn does have an effect, and all the bots now fail to build 'cause they build "chromium_builder_asan", a target that doesn't exist in the gn build. > > Reverting to get back to a working state. I'll look at fixing and will hopefully reland this soon. > > Original issue's description: > > Flip Linux bots on chromium.lkgr to GN. > > > > R=brettw@chromium.org, inferno@chromium.org > > BUG=605732 > > > > Committed: https://crrev.com/6864dbb0407a47f697901f70105d2c2c829c08bc > > Cr-Commit-Position: refs/heads/master@{#398038} > > TBR=brettw@chromium.org,inferno@chromium.org,dpranke@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=605732 > > Committed: https://crrev.com/424b728048335ebf880781b600f65fc7d993e206 > Cr-Commit-Position: refs/heads/master@{#398904} TBR=brettw@chromium.org,inferno@chromium.org,dpranke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=605732 Committed: https://crrev.com/e4e9b9ce3b7b6309477ac846f5ff8b565745fd75 Cr-Commit-Position: refs/heads/master@{#399261}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -48 lines) Patch
M tools/mb/mb_config.pyl View 5 chunks +48 lines, -48 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Nico
Created Reland of Flip Linux bots on chromium.lkgr to GN.
4 years, 6 months ago (2016-06-10 19:08:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057193003/1
4 years, 6 months ago (2016-06-10 19:08:39 UTC) #3
inferno
lgtm
4 years, 6 months ago (2016-06-10 19:18:18 UTC) #4
Dirk Pranke
lgtm also.
4 years, 6 months ago (2016-06-10 19:28:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 20:19:12 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 20:19:13 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e4e9b9ce3b7b6309477ac846f5ff8b565745fd75 Cr-Commit-Position: refs/heads/master@{#399261}
4 years, 6 months ago (2016-06-10 20:22:29 UTC) #9
Nico
4 years, 6 months ago (2016-06-13 09:08:40 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2063673002/ by thakis@chromium.org.

The reason for reverting is: This breaks:

* UBSan vptr Release:
https://build.chromium.org/p/chromium.lkgr/builders/UBSan%20vptr%20Release/bu...
clang: error: argument unused during compilation: '-fsanitize-coverage=edge'
This is https://crbug.com/618534

* The 3 32-bit x86 with 32-bit arm v8 asan bots, e.g.
https://build.chromium.org/p/chromium.lkgr/builders/ASan%20Debug%20%2832-bit%...
../../v8/src/base/build_config.h:145:2: error: Target architecture ia32 is only
supported on ia32 host
#error Target architecture ia32 is only supported on ia32 host
 ^
I filed https://crbug.com/619503 for this..

Powered by Google App Engine
This is Rietveld 408576698