Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2057193002: Revert of Attempt to deflake video-layer-crash.html. (Closed)

Created:
4 years, 6 months ago by jbroman
Modified:
4 years, 6 months ago
Reviewers:
xidachen
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Attempt to deflake video-layer-crash.html. (patchset #1 id:1 of https://codereview.chromium.org/2053793002/ ) Reason for revert: Didn't deflake -- and there should be a synchronous layout/paint before pixel dump anyhow. Original issue's description: > Attempt to deflake video-layer-crash.html. > > This makes the test wait for layout and paint, instead of finishing the test as > soon as the seeked event is seen. Currently the Retina bot flakily produces the > frame previous to the one that is expected. > > BUG=618693 > > Committed: https://crrev.com/4990c8699c14f2c7226b901c11ea45a810d93c63 > Cr-Commit-Position: refs/heads/master@{#399010} TBR=xidachen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=618693 Committed: https://crrev.com/5f0ab9c835e3f55e0d073239a75a4a73c1e61836 Cr-Commit-Position: refs/heads/master@{#399189}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/media/video-paint-test.js View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbroman
Created Revert of Attempt to deflake video-layer-crash.html.
4 years, 6 months ago (2016-06-10 15:36:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057193002/1
4 years, 6 months ago (2016-06-10 15:37:27 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 15:38:03 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 15:38:05 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 15:39:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f0ab9c835e3f55e0d073239a75a4a73c1e61836
Cr-Commit-Position: refs/heads/master@{#399189}

Powered by Google App Engine
This is Rietveld 408576698