Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1133)

Unified Diff: third_party/WebKit/Source/core/frame/HostsUsingFeatures.h

Issue 2057153002: Add GetUserMedia ETLD+1 rappor metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change approach to use per-document instead of per-call stats, update metric names Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/HostsUsingFeatures.h
diff --git a/third_party/WebKit/Source/core/frame/HostsUsingFeatures.h b/third_party/WebKit/Source/core/frame/HostsUsingFeatures.h
index 7abe773a04536066cef7a85b4eefdab3dad3d309..a15ca5790d518d8ff981171c4e7583912ae52922 100644
--- a/third_party/WebKit/Source/core/frame/HostsUsingFeatures.h
+++ b/third_party/WebKit/Source/core/frame/HostsUsingFeatures.h
@@ -16,6 +16,7 @@ namespace blink {
class Document;
class EventTarget;
+class KURL;
class ScriptState;
class CORE_EXPORT HostsUsingFeatures {
@@ -37,6 +38,8 @@ public:
ElementAttachShadow,
ApplicationCacheManifestSelectInsecureHost,
ApplicationCacheAPIInsecureHost,
+ GetUserMediaInsecureETLDPlus1,
+ GetUserMediaSecureETLDPlus1,
NumberOfFeatures // This must be the last item.
};
@@ -60,7 +63,7 @@ public:
bool get(Feature feature) const { return m_countBits & (1 << static_cast<unsigned>(feature)); }
void aggregate(Value);
- void recordHostToRappor(const String& host);
+ void recordURLToRappor(const KURL&);
void recordNameToRappor(const String& name);
private:
@@ -72,10 +75,10 @@ public:
void clear();
private:
- void recordHostToRappor();
+ void recordURLToRappor();
void recordNamesToRappor();
- Vector<std::pair<String, HostsUsingFeatures::Value>, 1> m_hostAndValues;
+ Vector<std::pair<String, HostsUsingFeatures::Value>, 1> m_urlAndValues;
jww 2016/06/11 18:43:21 nit: Why store the serialized URL and not just the
Guido Urdaneta 2016/06/12 11:06:22 Done.
HashMap<String, HostsUsingFeatures::Value> m_valueByName;
};

Powered by Google App Engine
This is Rietveld 408576698