Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp

Issue 2057153002: Add GetUserMedia ETLD+1 rappor metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix email Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/rappor/rappor.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp
diff --git a/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp b/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp
index f869e7822a0b3ae61093454c11113a0b13b4df51..17da6a2c1edd51e194ebdfa780a8bc3f9dd2ab69 100644
--- a/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp
+++ b/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp
@@ -46,6 +46,7 @@
#include "modules/mediastream/UserMediaController.h"
#include "platform/mediastream/MediaStreamCenter.h"
#include "platform/mediastream/MediaStreamDescriptor.h"
+#include "public/platform/Platform.h"
namespace blink {
@@ -133,6 +134,7 @@ bool UserMediaRequest::isSecureContextUse(String& errorMessage)
UseCounter::count(document->frame(), UseCounter::GetUserMediaSecureOrigin);
UseCounter::countCrossOriginIframe(*document, UseCounter::GetUserMediaSecureOriginIframe);
HostsUsingFeatures::countAnyWorld(*document, HostsUsingFeatures::Feature::GetUserMediaSecureHost);
+ Platform::current()->recordRapporURL("GetUserMedia.SecureOrigin", WebURL(document->url()));
Guido Urdaneta 2016/06/10 12:47:49 Is "GetUserMedia.SecureOrigin" a good name for thi
tommi (sloooow) - chröme 2016/06/10 13:19:36 Sounds reasonable to me and consistent with how th
return true;
}
@@ -141,6 +143,7 @@ bool UserMediaRequest::isSecureContextUse(String& errorMessage)
Deprecation::countDeprecation(document->frame(), UseCounter::GetUserMediaInsecureOrigin);
Deprecation::countDeprecationCrossOriginIframe(*document, UseCounter::GetUserMediaInsecureOriginIframe);
HostsUsingFeatures::countAnyWorld(*document, HostsUsingFeatures::Feature::GetUserMediaInsecureHost);
+ Platform::current()->recordRapporURL("GetUserMedia.InsecureOrigin", WebURL(document->url()));
return false;
}
« no previous file with comments | « no previous file | tools/metrics/rappor/rappor.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698