Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1264)

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/service_exception_view.html

Issue 205713004: Add isolate tag-profile and better handling of errors (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/elements/service_exception_view.html
diff --git a/runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/error_view.html b/runtime/bin/vmservice/client/lib/src/elements/service_exception_view.html
similarity index 55%
copy from runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/error_view.html
copy to runtime/bin/vmservice/client/lib/src/elements/service_exception_view.html
index ed1c7fb3ff75d564283274ddddd16b3244884b3d..200dc426bedb4cc3663080dbb56de542c4802b68 100644
--- a/runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/error_view.html
+++ b/runtime/bin/vmservice/client/lib/src/elements/service_exception_view.html
@@ -2,7 +2,7 @@
<link rel="import" href="nav_bar.html">
<link rel="import" href="observatory_element.html">
</head>
-<polymer-element name="error-view" extends="observatory-element">
+<polymer-element name="service-exception-view" extends="observatory-element">
<template>
<nav-bar>
<top-nav-menu last="{{ true }}"></top-nav-menu>
@@ -11,13 +11,16 @@
<div class="row">
<div class="col-md-8 col-md-offset-2">
<div class="panel panel-danger">
- <div class="panel-heading">{{ error.kind }}</div>
+ <div class="panel-heading">{{ exception.kind }}</div>
<div class="panel-body">
- <p>{{ error.message }}</p>
+ <p>{{ exception.message }}</p>
+ </div>
+ <div class="well">
+ <p>{{ exception.response }}</p>
</div>
</div>
</div>
</div>
</template>
- <script type="application/dart" src="error_view.dart"></script>
+ <script type="application/dart" src="service_exception_view.dart"></script>
</polymer-element>

Powered by Google App Engine
This is Rietveld 408576698