Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Unified Diff: runtime/bin/vmservice/client/deployed/web/index_devtools.html

Issue 205713004: Add isolate tag-profile and better handling of errors (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/deployed/web/index_devtools.html
diff --git a/runtime/bin/vmservice/client/deployed/web/index_devtools.html b/runtime/bin/vmservice/client/deployed/web/index_devtools.html
index 4fa9c30a9792d079e1de6c1cf94fc24fa3fd669a..f51ef56a4ef62d935b0038501391a6b9a575942e 100644
--- a/runtime/bin/vmservice/client/deployed/web/index_devtools.html
+++ b/runtime/bin/vmservice/client/deployed/web/index_devtools.html
@@ -1040,6 +1040,37 @@
</div>
</div>
+ <template if="{{ isolate.error != null }}">
+ <div class="content">
+ <h1>Error</h1>
+ <div class="memberList">
+ <div class="memberItem">
+ <div class="memberName">message</div>
+ <div class="memberValue">
+ <pre>{{ isolate.error.message }}</pre>
+ </div>
+ </div>
+ <div class="memberItem">
+ <template if="{{ isolate.error.exception != null }}">
+ <div class="memberName">exception</div>
+ <div class="memberValue">
+ <instance-ref ref="{{ isolate.error.exception }}"></instance-ref>
+ </div>
+ </template>
+ </div>
+ <div class="memberItem">
+ <template if="{{ isolate.error.stacktrace != null }}">
+ <div class="memberName">stacktrace</div>
+ <div class="memberValue">
+ <instance-ref ref="{{ isolate.error.stacktrace }}"></instance-ref>
+ </div>
+ </template>
+ </div>
+ </div>
+ </div>
+ <hr>
+ </template>
+
<template if="{{ isolate.topFrame != null }}">
<br>
<div class="sourceInset">
@@ -1130,6 +1161,12 @@
<hr>
<div class="content">
+ <div id="tagProfileChart" class="col-md-8" style="height: 400px"></div>
+ </div>
+
+ <hr>
+
+ <div class="content">
<eval-box callback="{{ eval }}"></eval-box>
</div>
<br><br><br><br>
@@ -1855,6 +1892,47 @@
</template>
</polymer-element>
+<polymer-element name="service-exception-view" extends="observatory-element">
+ <template>
+ <nav-bar>
+ <top-nav-menu last="{{ true }}"></top-nav-menu>
+ </nav-bar>
+
+ <div class="row">
+ <div class="col-md-8 col-md-offset-2">
+ <div class="panel panel-danger">
+ <div class="panel-heading">{{ exception.kind }}</div>
+ <div class="panel-body">
+ <p>{{ exception.message }}</p>
+ </div>
+ <div class="well">
+ <p>{{ exception.response }}</p>
+ </div>
+ </div>
+ </div>
+ </div>
+ </template>
+
+</polymer-element>
+<polymer-element name="service-error-view" extends="observatory-element">
+ <template>
+ <nav-bar>
+ <top-nav-menu last="{{ true }}"></top-nav-menu>
+ </nav-bar>
+
+ <div class="row">
+ <div class="col-md-8 col-md-offset-2">
+ <div class="panel panel-danger">
+ <div class="panel-heading">{{ error.kind }}</div>
+ <div class="panel-body">
+ <p>{{ error.message }}</p>
+ </div>
+ </div>
+ </div>
+ </div>
+ </template>
+
+</polymer-element>
<polymer-element name="vm-ref" extends="service-ref">
<template>
<a href="{{ url }}">{{ ref.name }}</a>

Powered by Google App Engine
This is Rietveld 408576698