[css-grid] Allow percentage values for column and row gutters

third_party/WebKit/Source/core/layout/LayoutGrid.h

 /*
  * Copyright (C) 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 53 matching lines @@
         ASSERT(!m_gridIsDirty);
         return m_columnPositions;
     }
 
     const Vector<LayoutUnit>& rowPositions() const
     {
         ASSERT(!m_gridIsDirty);
         return m_rowPositions;
     }
 
-    LayoutUnit guttersSize(GridTrackSizingDirection, size_t span) const;
+    LayoutUnit guttersSize(GridTrackSizingDirection, size_t span, LayoutUnit availableSize) const;

[Manuel Rego, 2016/07/01 06:45:57]

I'm not really convinced about this API, specially it being public.

From the outside you shouldn't need to pass the avilableSize,
it should always use the availableLogicalWidth|Height() to determine
the gutter.

On top of that, we're already passing different values here
(contentLogicalWidth(),
availableLogicalWidth(), logicalWidth()). And this is just the initial patch,
we can pass more things in the future.

I really believe we should be able to do it internally, my approach would be
passing
the SizingOperation (actually in the public method don't pass anything
as it'd always be TrackSizing):
A) If we're computing intrinsic sizes the availableSize is always 0.
B) If we're in the track sizing phase, for columns the availableSize is
availableLogicalWidth()
   for rows, if the height of the grid container is indefinite it's 0,
  otherwise it's the availableLogicalHeight().

In most cases we'll be using the B) so that could be the default.

That way we avoid to pass this size over and over.

[svillar, 2016/07/13 09:08:08]

FWIW I'm making it private in the auto-fit patch.

 
     LayoutUnit offsetBetweenTracks(GridTrackSizingDirection direction) const
     {
         return direction == ForColumns ? m_offsetBetweenColumns : m_offsetBetweenRows;
     }
 
     typedef Vector<LayoutBox*, 1> GridCell;
     const GridCell& gridCell(int row, int column) const
     {
         ASSERT_WITH_SECURITY_IMPLICATION(!m_gridIsDirty);
@@ skipping 146 matching lines @@
     size_t m_autoRepeatRows { 0 };
 
     bool m_hasAnyOrthogonalChild;
 };
 
 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutGrid, isLayoutGrid());
 
 } // namespace blink
 
 #endif // LayoutGrid_h