Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2057103004: Pass SetServerCertificate call on (Closed)

Created:
4 years, 6 months ago by jrummell
Modified:
4 years, 6 months ago
Reviewers:
xhwang
CC:
chromium-reviews, eme-reviews_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass SetServerCertificate call on Have SetServerCertificate() call the matching method on |decryptor_| rather than resolving the promise immediately. This allows External Clear Key to more closely match the functionality of Clear Key. BUG=618800 TEST=encrypted media browser tests pass Committed: https://crrev.com/1af40e160276b4bd756bed244c1b3709b9ba417f Cr-Commit-Position: refs/heads/master@{#399520}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M media/cdm/ppapi/external_clear_key/clear_key_cdm.cc View 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
jrummell
PTAL. Noticed this when looking at how SetServerCertificate handles NOT_SUPPORTED.
4 years, 6 months ago (2016-06-10 23:56:09 UTC) #2
xhwang
lgtm
4 years, 6 months ago (2016-06-11 00:00:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057103004/1
4 years, 6 months ago (2016-06-13 18:56:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 20:15:32 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 20:15:34 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 20:17:35 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1af40e160276b4bd756bed244c1b3709b9ba417f
Cr-Commit-Position: refs/heads/master@{#399520}

Powered by Google App Engine
This is Rietveld 408576698