Tune the memory pressure handler to perform a second GC immediately

src/heap/heap.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/heap/heap.h"
 
 #include "src/accessors.h"
 #include "src/api.h"
 #include "src/ast/scopeinfo.h"
 #include "src/base/bits.h"
@@ skipping 4448 matching lines @@
       StartIdleIncrementalMarking();
     }
   }
   MemoryReducer::Event event;
   event.type = MemoryReducer::kPossibleGarbage;
   event.time_ms = MonotonicallyIncreasingTimeInMs();
   memory_reducer_->NotifyPossibleGarbage(event);
 }
 
 void Heap::CollectGarbageOnMemoryPressure(const char* source) {
+  const int kGarbageThresholdInBytes = 8 * MB;
+  const double kGarbageThresholdAsFractionOfTotalMemory = 0.1;
+  const double kMaxMemoryPressurePauseMs = 100;

[Michael Lippautz, 2016/06/10 11:20:34]

nit: If you can, please document why 100ms. (I was not part of all discussions
when this API landed.)

[ulan, 2016/06/10 11:36:01]

Done.

+
+  double start = MonotonicallyIncreasingTimeInMs();
   CollectAllGarbage(kReduceMemoryFootprintMask | kAbortIncrementalMarkingMask,
-                    source);
+                    source, kGCCallbackFlagCollectAllAvailableGarbage);
+  new_space_.Shrink();

[Michael Lippautz, 2016/06/10 11:20:34]

Why is the shrinking needed? This should be done through
GarbageCollectionEpilogue as ShouldReduceMemory() is true?

[ulan, 2016/06/10 11:36:01]

Yes, thanks. Done.

+  double end = MonotonicallyIncreasingTimeInMs();
+
+  // Estimate how much memory we can free.
+  int64_t potential_garbage = (CommittedMemory() - SizeOfObjects()) +
+                              amount_of_external_allocated_memory_;
+  // If we can potentially free large amount of memory, then start GC right
+  // away instead of waiting for memory reducer.
+  if (potential_garbage >= kGarbageThresholdInBytes &&
+      potential_garbage >=
+          CommittedMemory() * kGarbageThresholdAsFractionOfTotalMemory) {
+    // If we spent less than half of the time budget, then perform full GC
+    // Otherwise, start incremental marking.
+    if (end - start < kMaxMemoryPressurePauseMs / 2) {
+      CollectAllGarbage(
+          kReduceMemoryFootprintMask | kAbortIncrementalMarkingMask, source,
+          kGCCallbackFlagCollectAllAvailableGarbage);
+    } else {
+      if (FLAG_incremental_marking && incremental_marking()->IsStopped()) {

[Michael Lippautz, 2016/06/10 11:20:34]

nit (not for now): At some point I think it would be good if maybe
StartIncrementalMarking and its variants would return a bool that returns
whether the start was successful. It's hard to remember that you have to check
the FLAG_ and IsStopped() when we want to start it.

[ulan, 2016/06/10 11:36:01]

Acknowledged.

+        StartIdleIncrementalMarking();
+      }
+    }
+  }
 }
 
 void Heap::MemoryPressureNotification(MemoryPressureLevel level,
                                       bool is_isolate_locked) {
   MemoryPressureLevel previous = memory_pressure_level_.Value();
   memory_pressure_level_.SetValue(level);
   if ((previous != MemoryPressureLevel::kCritical &&
        level == MemoryPressureLevel::kCritical) ||
       (previous == MemoryPressureLevel::kNone &&
        level == MemoryPressureLevel::kModerate)) {
@@ skipping 1944 matching lines @@
 }
 
 
 // static
 int Heap::GetStaticVisitorIdForMap(Map* map) {
   return StaticVisitorBase::GetVisitorId(map);
 }
 
 }  // namespace internal
 }  // namespace v8