Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Side by Side Diff: third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.h

Issue 2057093002: Removed unnecessary mutable in SiblingData. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef StyleInvalidator_h 5 #ifndef StyleInvalidator_h
6 #define StyleInvalidator_h 6 #define StyleInvalidator_h
7 7
8 #include "core/css/invalidation/PendingInvalidations.h" 8 #include "core/css/invalidation/PendingInvalidations.h"
9 #include "platform/heap/Handle.h" 9 #include "platform/heap/Handle.h"
10 #include "wtf/Noncopyable.h" 10 #include "wtf/Noncopyable.h"
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 }; 62 };
63 63
64 class SiblingData { 64 class SiblingData {
65 STACK_ALLOCATED(); 65 STACK_ALLOCATED();
66 public: 66 public:
67 SiblingData() 67 SiblingData()
68 : m_elementIndex(0) 68 : m_elementIndex(0)
69 { } 69 { }
70 70
71 void pushInvalidationSet(const SiblingInvalidationSet&); 71 void pushInvalidationSet(const SiblingInvalidationSet&);
72 bool matchCurrentInvalidationSets(Element&, RecursionData&) const; 72 bool matchCurrentInvalidationSets(Element&, RecursionData&);
73 73
74 bool isEmpty() const { return m_invalidationEntries.isEmpty(); } 74 bool isEmpty() const { return m_invalidationEntries.isEmpty(); }
75 void advance() { m_elementIndex++; } 75 void advance() { m_elementIndex++; }
76 76
77 private: 77 private:
78 struct Entry { 78 struct Entry {
79 DISALLOW_NEW_EXCEPT_PLACEMENT_NEW(); 79 DISALLOW_NEW_EXCEPT_PLACEMENT_NEW();
80 Entry(const SiblingInvalidationSet* invalidationSet, unsigned invali dationLimit) 80 Entry(const SiblingInvalidationSet* invalidationSet, unsigned invali dationLimit)
81 : m_invalidationSet(invalidationSet) 81 : m_invalidationSet(invalidationSet)
82 , m_invalidationLimit(invalidationLimit) 82 , m_invalidationLimit(invalidationLimit)
83 {} 83 {}
84 84
85 const SiblingInvalidationSet* m_invalidationSet; 85 const SiblingInvalidationSet* m_invalidationSet;
86 unsigned m_invalidationLimit; 86 unsigned m_invalidationLimit;
87 }; 87 };
88 88
89 mutable Vector<Entry, 16> m_invalidationEntries; 89 Vector<Entry, 16> m_invalidationEntries;
90 unsigned m_elementIndex; 90 unsigned m_elementIndex;
91 }; 91 };
92 92
93 bool invalidate(Element&, RecursionData&, SiblingData&); 93 bool invalidate(Element&, RecursionData&, SiblingData&);
94 bool invalidateShadowRootChildren(Element&, RecursionData&); 94 bool invalidateShadowRootChildren(Element&, RecursionData&);
95 bool invalidateChildren(Element&, RecursionData&); 95 bool invalidateChildren(Element&, RecursionData&);
96 void invalidateSlotDistributedElements(HTMLSlotElement&, const RecursionData &) const; 96 void invalidateSlotDistributedElements(HTMLSlotElement&, const RecursionData &) const;
97 bool checkInvalidationSetsAgainstElement(Element&, RecursionData&, SiblingDa ta&); 97 bool checkInvalidationSetsAgainstElement(Element&, RecursionData&, SiblingDa ta&);
98 void pushInvalidationSetsForElement(Element&, RecursionData&, SiblingData&); 98 void pushInvalidationSetsForElement(Element&, RecursionData&, SiblingData&);
99 99
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 using PendingInvalidationMap = HeapHashMap<Member<Element>, OwnPtr<PendingIn validations>>; 131 using PendingInvalidationMap = HeapHashMap<Member<Element>, OwnPtr<PendingIn validations>>;
132 132
133 PendingInvalidations& ensurePendingInvalidations(Element&); 133 PendingInvalidations& ensurePendingInvalidations(Element&);
134 134
135 PendingInvalidationMap m_pendingInvalidationMap; 135 PendingInvalidationMap m_pendingInvalidationMap;
136 }; 136 };
137 137
138 } // namespace blink 138 } // namespace blink
139 139
140 #endif // StyleInvalidator_h 140 #endif // StyleInvalidator_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698