chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm - Issue 2057043002: Align the Mac Omnibox items vertically again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm

Issue 2057043002: Align the Mac Omnibox items vertically again. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm

index 19889e9a3e59135a2964b300f264ef053283a17e..994681084cee4a506f75ae47094b28ac77f42eca 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm

@@ -152,8 +152,11 @@ const NSInteger kMiddleButtonNumber = 2;

base::scoped_nsobject<NSLayoutManager> layoutManager(

[[NSLayoutManager alloc] init]);

answerLineHeight_ =

- [layoutManager defaultLineHeightForFont:OmniboxViewMac::GetLargeFont()];

+ [layoutManager defaultLineHeightForFont:OmniboxViewMac::GetLargeFont(

tapted 2016/06/14 05:51:34 defaultLineHeightForFont has a rounding bug - see

+ gfx::Font::NORMAL,

+ gfx::Font::Weight::NORMAL)];

}

return self;

}