Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8969)

Unified Diff: chrome/browser/signin/signin_manager.cc

Issue 205703005: Componentize SigninIdAccountHelper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Response to review Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/signin/signin_account_id_helper.cc ('k') | chrome/common/pref_names.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/signin_manager.cc
diff --git a/chrome/browser/signin/signin_manager.cc b/chrome/browser/signin/signin_manager.cc
index b90d5afd43410b461aa948e308ef1ac7ae863a5d..dcaf9ab8523613ca9121a5c397ee24da7813ae0d 100644
--- a/chrome/browser/signin/signin_manager.cc
+++ b/chrome/browser/signin/signin_manager.cc
@@ -14,7 +14,6 @@
#include "base/time/time.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/profiles/profile_io_data.h"
-#include "chrome/browser/signin/local_auth.h"
#include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
#include "chrome/browser/signin/signin_account_id_helper.h"
#include "chrome/common/pref_names.h"
@@ -301,7 +300,10 @@ void SigninManager::Initialize(Profile* profile, PrefService* local_state) {
}
InitTokenService();
- account_id_helper_.reset(new SigninAccountIdHelper(profile_, this));
+ account_id_helper_.reset(new SigninAccountIdHelper(
+ client_,
+ ProfileOAuth2TokenServiceFactory::GetForProfile(profile_),
+ this));
}
void SigninManager::Shutdown() {
@@ -436,11 +438,7 @@ void SigninManager::OnSignedIn(const std::string& username) {
GoogleSigninSucceeded(GetAuthenticatedUsername(),
password_));
-#if !defined(OS_ANDROID)
- // Don't store password hash except for users of new profile features.
- if (switches::IsNewProfileManagement())
- chrome::SetLocalAuthCredentials(profile_, password_);
-#endif
+ client_->GoogleSigninSucceeded(GetAuthenticatedUsername(), password_);
password_.clear(); // Don't need it anymore.
DisableOneClickSignIn(profile_); // Don't ever offer again.
« no previous file with comments | « chrome/browser/signin/signin_account_id_helper.cc ('k') | chrome/common/pref_names.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698