Componentize SigninIdAccountHelper.

chrome/browser/signin/chrome_signin_client.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SIGNIN_CHROME_SIGNIN_CLIENT_H_
 #define CHROME_BROWSER_SIGNIN_CHROME_SIGNIN_CLIENT_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
+#include "base/memory/scoped_ptr.h"
 #include "components/keyed_service/core/keyed_service.h"
 #include "components/signin/core/signin_client.h"
 
 class CookieSettings;
 class Profile;
+class SigninAccountIdHelper;
 
 class ChromeSigninClient : public SigninClient, public KeyedService {
  public:
   explicit ChromeSigninClient(Profile* profile);
   virtual ~ChromeSigninClient();
 
   // Utility methods.
   static bool ProfileAllowsSigninCookies(Profile* profile);
   static bool SettingsAllowSigninCookies(CookieSettings* cookie_settings);
 
   // SigninClient implementation.
   virtual scoped_refptr<TokenWebData> GetDatabase() OVERRIDE;
   virtual bool CanRevokeCredentials() OVERRIDE;
   virtual net::URLRequestContextGetter* GetURLRequestContext() OVERRIDE;
+  virtual void GoogleSigninSucceeded(const std::string& username,
+                                     const std::string& password) OVERRIDE;
+
+#if !defined(OS_CHROMEOS)

[blundell, 2014/03/21 15:01:46]

I decided to make this API non-ChromeOS to make it clear that these functions
wouldn't be called when only SigninManagerBase was used (to preserve the
previous behavior wrt SigninIdAccountHelper, I need to call these functions from
SigninManager rather than SigninManagerBase). It's a little ugly, but IIUC
SigninIdAccountHelper will be going away soon, at which point these functions
can go away too. Anyway, open to other ideas if you have them. 

+  virtual void SigninManagerInitialized(SigninManager* manager) OVERRIDE;
+  virtual void SigninManagerShutdown(SigninManager* manager) OVERRIDE;
+#endif
 
  private:
   Profile* profile_;
 
+  // Fetcher for the obfuscated user id.
+  scoped_ptr<SigninAccountIdHelper> account_id_helper_;
+
   DISALLOW_COPY_AND_ASSIGN(ChromeSigninClient);
 };
 
 #endif  // CHROME_BROWSER_SIGNIN_CHROME_SIGNIN_CLIENT_H_