Issue 205703004: Let auto-roll push the lkgr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 205703004: Let auto-roll push the lkgr. (Closed)

Created:
6 years, 9 months ago by Michael Achenbach

Modified:
6 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev, Jarin

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Let auto-roll push the lkgr. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20168

Patch Set 2 : Review #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -49 lines)			Patch
	M	tools/push-to-trunk/auto_roll.py	View	1	4 chunks	+36 lines, -42 lines	0 comments	Download
	M	tools/push-to-trunk/test_scripts.py	View		4 chunks	+9 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with nit. https://codereview.chromium.org/205703004/diff/1/tools/push-to-trunk/auto_roll.py File tools/push-to-trunk/auto_roll.py (right): https://codereview.chromium.org/205703004/diff/1/tools/push-to-trunk/auto_roll.py#newcode143 tools/push-to-trunk/auto_roll.py:143: "-R", self["lkgr"], nit: please use long ...

6 years, 9 months ago (2014-03-21 14:32:38 UTC) #2

Michael Achenbach

6 years, 9 months ago (2014-03-21 15:05:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20168 (presubmit successful).

Expand Messages | Collapse Messages

Issue 205703004: Let auto-roll push the lkgr. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Review #

Messages