Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: media/filters/pipeline_integration_test.cc

Issue 205703003: MSE: Use frame duration, if available, in LegacyFrameProcessor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/pipeline_integration_test.cc
diff --git a/media/filters/pipeline_integration_test.cc b/media/filters/pipeline_integration_test.cc
index 05ba99343f6875e07ea6c19af21e6ec5a58d1087..9693af96c01b9104bd961db4bd37a4dd2395ad96 100644
--- a/media/filters/pipeline_integration_test.cc
+++ b/media/filters/pipeline_integration_test.cc
@@ -61,14 +61,14 @@ const int kAppendTimeMs = kAppendTimeSec * 1000;
const int k320WebMFileDurationMs = 2737;
const int k640WebMFileDurationMs = 2763;
const int kOpusEndTrimmingWebMFileDurationMs = 2771;
-const int kVP9WebMFileDurationMs = 2703;
-const int kVP8AWebMFileDurationMs = 2700;
+const int kVP9WebMFileDurationMs = 2737;
+const int kVP8AWebMFileDurationMs = 2734;
#if defined(USE_PROPRIETARY_CODECS)
const int k640IsoFileDurationMs = 2737;
const int k640IsoCencFileDurationMs = 2736;
const int k1280IsoFileDurationMs = 2736;
-const int k1280IsoAVC3FileDurationMs = 2735;
+const int k1280IsoAVC3FileDurationMs = 2736;
#endif // defined(USE_PROPRIETARY_CODECS)
// Note: Tests using this class only exercise the DecryptingDemuxerStream path.
@@ -573,7 +573,11 @@ TEST_F(PipelineIntegrationTest, BasicPlayback_MediaSource_Opus_WebM) {
EXPECT_EQ(1u, pipeline_->GetBufferedTimeRanges().size());
EXPECT_EQ(0, pipeline_->GetBufferedTimeRanges().start(0).InMilliseconds());
- EXPECT_EQ(kOpusEndTrimmingWebMFileDurationMs,
+ // TODO(acolwell/wolenetz): Drop the "+ 1" once WebM stream parser always
+ // emits frames with valid durations (see http://crbug.com/351166) and
+ // compliant coded frame processor's "highest presentation end timestamp" is
+ // used to update duration (see http://crbug.com/249422).
+ EXPECT_EQ(kOpusEndTrimmingWebMFileDurationMs + 1,
pipeline_->GetBufferedTimeRanges().end(0).InMilliseconds());
Play();
@@ -592,7 +596,11 @@ TEST_F(PipelineIntegrationTest, DISABLED_MediaSource_Opus_Seeking_WebM) {
EXPECT_EQ(1u, pipeline_->GetBufferedTimeRanges().size());
EXPECT_EQ(0, pipeline_->GetBufferedTimeRanges().start(0).InMilliseconds());
- EXPECT_EQ(kOpusEndTrimmingWebMFileDurationMs,
+ // TODO(acolwell/wolenetz): Drop the "+ 1" once WebM stream parser always
+ // emits frames with valid durations (see http://crbug.com/351166) and
+ // compliant coded frame processor's "highest presentation end timestamp" is
+ // used to update duration (see http://crbug.com/249422).
+ EXPECT_EQ(kOpusEndTrimmingWebMFileDurationMs + 1,
pipeline_->GetBufferedTimeRanges().end(0).InMilliseconds());
base::TimeDelta start_seek_time = base::TimeDelta::FromMilliseconds(1000);
« media/filters/legacy_frame_processor.cc ('K') | « media/filters/legacy_frame_processor.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698