Adds support for new-tab targeted loads initiated from the renderer.

services/navigation/view_impl.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/navigation/view_impl.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "components/mus/public/cpp/window_tree_client.h"
 #include "content/public/browser/interstitial_page.h"
 #include "content/public/browser/interstitial_page_delegate.h"
@@ skipping 141 matching lines @@
 
   // TODO(beng): this reply is currently synchronous, figure out a fix.
   if (was_blocked)
     *was_blocked = false;
 }
 
 void ViewImpl::CloseContents(content::WebContents* source) {
   client_->Close();
 }
 
+content::WebContents* ViewImpl::OpenURLFromTab(
+    content::WebContents* source,
+    const content::OpenURLParams& params) {
+  mojom::OpenURLParamsPtr params_ptr = mojom::OpenURLParams::New();
+  params_ptr->url = params.url;
+  params_ptr->disposition =
+      static_cast<mojom::WindowOpenDisposition>(params.disposition);
+  client_->OpenURL(std::move(params_ptr));
+  // TODO(beng): Obviously this is the wrong thing to return for dispositions
+  // that would lead to the creation of a new View, i.e. NEW_TAB, NEW_POPUP etc.
+  // However it seems the callers of this function that we've seen so far
+  // disregard the return value. Rather than returning |source| I'm returning
+  // nullptr to locate (via crash) any sites that depend on a valid result.
+  // If we actually had to do this then we'd have to create the new WebContents
+  // here, store it with a cookie, and pass the cookie through to the client to
+  // pass back with their call to CreateView(), so it would get bound to the
+  // WebContents.
+  return nullptr;
+}
+
 void ViewImpl::LoadingStateChanged(content::WebContents* source,
                                    bool to_different_document) {
   client_->LoadingStateChanged(source->IsLoading());
 }
 
 void ViewImpl::NavigationStateChanged(content::WebContents* source,
                                       content::InvalidateTypes changed_flags) {
   client_->NavigationStateChanged(source->GetVisibleURL(),
                                   base::UTF16ToUTF8(source->GetTitle()),
                                   source->GetController().CanGoBack(),
@@ skipping 12 matching lines @@
 gfx::Rect ViewImpl::GetRootWindowResizerRect() const {
   gfx::Rect bounds = web_view_->GetLocalBounds();
   return gfx::Rect(bounds.right() - resizer_size_.width(),
                    bounds.bottom() - resizer_size_.height(),
                    resizer_size_.width(), resizer_size_.height());
 }
 
 void ViewImpl::Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) {
-  DCHECK(content::Source<content::NavigationController>(source).ptr() ==
-         &web_view_->GetWebContents()->GetController());
+  if (content::Source<content::NavigationController>(source).ptr() !=
+      &web_view_->GetWebContents()->GetController()) {
+    return;
+  }
+
   switch (type) {
     case content::NOTIFICATION_NAV_ENTRY_PENDING: {
       const content::NavigationEntry* entry =
           content::Details<content::NavigationEntry>(details).ptr();
       client_->NavigationPending(EntryPtrFromNavEntry(*entry));
       break;
     }
     case content::NOTIFICATION_NAV_ENTRY_COMMITTED: {
       const content::LoadCommittedDetails* lcd =
           content::Details<content::LoadCommittedDetails>(details).ptr();
@@ skipping 52 matching lines @@
 
 views::Widget* ViewImpl::GetWidget() {
   return web_view_->GetWidget();
 }
 
 const views::Widget* ViewImpl::GetWidget() const {
   return web_view_->GetWidget();
 }
 
 }  // navigation