Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: third_party/WebKit/Source/core/html/HTMLFormElement.cpp

Issue 2057013002: Merge "UseCounter: Count form submission in orphan tree." to M52 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/frame/UseCounter.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLFormElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLFormElement.cpp b/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
index db015fc469f5a3074b5ec72296455beb1effd92f..8c7155f0084461c49da277afeb7362a52f13eb45 100644
--- a/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
@@ -340,6 +340,9 @@ void HTMLFormElement::submit(Event* event, bool activateSubmitButton)
LocalFrame* frame = document().frame();
if (!view || !frame || !frame->page())
return;
+ // See crbug.com/586749.
+ if (!inShadowIncludingDocument())
+ UseCounter::count(document(), UseCounter::FormSubmissionNotInDocumentTree);
if (m_isSubmittingOrInUserJSSubmitEvent) {
m_shouldSubmit = true;
« no previous file with comments | « third_party/WebKit/Source/core/frame/UseCounter.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698