Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2056993004:
Parser: Desugar default derived constructor to spread/rest (Closed)
DescriptionParser: Desugar default derived constructor to spread/rest
This patch declares a new rest parameter for the derived constructor,
and passes it to base constructor after calling PrepareSpreadArguments.
This patch also updates the test262.status to account for
the now passing test.
BUG=v8:4890
Committed: https://crrev.com/e681eea1f11177f79a7ea94f51d59936db398a01
Cr-Commit-Position: refs/heads/master@{#36939}
Patch Set 1 #Patch Set 2 : user preparespreadarguments #Patch Set 3 : update comment #Patch Set 4 : move parameter declaration inside if block #Patch Set 5 : make rest arg optional #
Total comments: 2
Patch Set 6 : remove whitespace #Messages
Total messages: 25 (12 generated)
Description was changed from ========== Parser: Desugar default derived constructor to spread/rest This patch declares a new rest parameter for the derived constructor, and passes it to base constructor after performing a spread operation. BUG=v8:4890 ========== to ========== Parser: Desugar default derived constructor to spread/rest This patch declares a new rest parameter for the derived constructor, and passes it to base constructor after performing a spread operation. This patch also updates the test262.status to account for the now passing test. BUG=v8:4890 ==========
The CQ bit was checked by gsathya@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056993004/20001
Description was changed from ========== Parser: Desugar default derived constructor to spread/rest This patch declares a new rest parameter for the derived constructor, and passes it to base constructor after performing a spread operation. This patch also updates the test262.status to account for the now passing test. BUG=v8:4890 ========== to ========== Parser: Desugar default derived constructor to spread/rest This patch declares a new rest parameter for the derived constructor, and passes it to base constructor after calling PrepareSpreadArguments. This patch also updates the test262.status to account for the now passing test. BUG=v8:4890 ==========
Description was changed from ========== Parser: Desugar default derived constructor to spread/rest This patch declares a new rest parameter for the derived constructor, and passes it to base constructor after calling PrepareSpreadArguments. This patch also updates the test262.status to account for the now passing test. BUG=v8:4890 ========== to ========== Parser: Desugar default derived constructor to spread/rest This patch declares a new rest parameter for the derived constructor, and passes it to base constructor after calling PrepareSpreadArguments. This patch also updates the test262.status to account for the now passing test. BUG=v8:4890 ==========
gsathya@chromium.org changed reviewers: + adamk@chromium.org, littledan@chromium.org
The CQ bit was checked by gsathya@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056993004/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/7139) v8_linux64_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...) v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...) v8_linux_arm_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng_trigger...)
The CQ bit was checked by gsathya@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056993004/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
PTAL, tests pass
lgtm https://codereview.chromium.org/2056993004/diff/80001/src/parsing/parser.cc File src/parsing/parser.cc (right): https://codereview.chromium.org/2056993004/diff/80001/src/parsing/parser.cc#n... src/parsing/parser.cc:195: Nit: revert whitespace change
https://codereview.chromium.org/2056993004/diff/80001/src/parsing/parser.cc File src/parsing/parser.cc (right): https://codereview.chromium.org/2056993004/diff/80001/src/parsing/parser.cc#n... src/parsing/parser.cc:195: On 2016/06/11 01:48:57, Dan Ehrenberg wrote: > Nit: revert whitespace change Done.
lgtm
The CQ bit was checked by gsathya@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056993004/100001
Message was sent while issue was closed.
Description was changed from ========== Parser: Desugar default derived constructor to spread/rest This patch declares a new rest parameter for the derived constructor, and passes it to base constructor after calling PrepareSpreadArguments. This patch also updates the test262.status to account for the now passing test. BUG=v8:4890 ========== to ========== Parser: Desugar default derived constructor to spread/rest This patch declares a new rest parameter for the derived constructor, and passes it to base constructor after calling PrepareSpreadArguments. This patch also updates the test262.status to account for the now passing test. BUG=v8:4890 ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Parser: Desugar default derived constructor to spread/rest This patch declares a new rest parameter for the derived constructor, and passes it to base constructor after calling PrepareSpreadArguments. This patch also updates the test262.status to account for the now passing test. BUG=v8:4890 ========== to ========== Parser: Desugar default derived constructor to spread/rest This patch declares a new rest parameter for the derived constructor, and passes it to base constructor after calling PrepareSpreadArguments. This patch also updates the test262.status to account for the now passing test. BUG=v8:4890 Committed: https://crrev.com/e681eea1f11177f79a7ea94f51d59936db398a01 Cr-Commit-Position: refs/heads/master@{#36939} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/e681eea1f11177f79a7ea94f51d59936db398a01 Cr-Commit-Position: refs/heads/master@{#36939} |
